Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit and Finish UX Fixes #1174

Merged
merged 20 commits into from
Oct 3, 2024
Merged

Conversation

jowg-amazon
Copy link
Contributor

Description

Addresses the fit and finish UX changes. Changes in this PR include:

  • Add a delete detector bulk action button to the left of the search bar instead of under actions
    Screenshot 2024-09-27 at 2 28 32 PM

  • Change getting started to get started
    Screenshot 2024-09-27 at 2 28 44 PM

  • Move refresh and action buttons inside the table on threat detectors page
    Screenshot 2024-09-27 at 2 29 12 PM

  • Move the tabs to the top of the page for findings and alerts pages
    Screenshot 2024-09-27 at 2 29 29 PM
    Screenshot 2024-09-27 at 2 29 39 PM

  • Add plus icon to left of create detector button
    Screenshot 2024-09-27 at 2 23 14 PM

  • Make search bar and filters compressed
    Screenshot 2024-09-27 at 2 30 32 PM

  • Change content panel title from H2 small to H3 small
    Screenshot 2024-09-27 at 2 31 07 PM

  • Fix spacing between all pages sections (16px)
    Screenshot 2024-09-27 at 2 25 22 PM

  • Remove hover state from empty message for Overview page widgets
    Screenshot 2024-09-27 at 2 25 58 PM

  • Change "total active alerts" to "total active threat alerts"
    Screenshot 2024-09-27 at 2 26 37 PM

  • Fix padding to 16px for all content panels
    Screenshot 2024-09-27 at 2 26 56 PM

  • Add period to end of correlate events description
    Screenshot 2024-09-27 at 2 27 32 PM

  • Fixes spacing from header to content when newHomePage isn't enabled

Screenshot 2024-09-27 at 4 25 00 PM

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
@jowg-amazon
Copy link
Contributor Author

Cypress tests passed locally

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  1_detectors.spec.js                      02:35       14       14        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  2_rules.spec.js                          02:11       17       17        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  3_alerts.spec.js                         02:51        7        7        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  4_findings.spec.js                       01:43        7        6        -        1        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        09:21       45       44        -        1        -  

Copy link
Collaborator

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

@AWSHurneyt AWSHurneyt merged commit 9c0c2f4 into opensearch-project:main Oct 3, 2024
7 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2024
* add plus sign to create detector button

Signed-off-by: Joanne Wang <[email protected]>

* change getting started to get started

Signed-off-by: Joanne Wang <[email protected]>

* run yarn test:jest -u

Signed-off-by: Joanne Wang <[email protected]>

* move tabs to top

Signed-off-by: Joanne Wang <[email protected]>

* remove duplicate code

Signed-off-by: Joanne Wang <[email protected]>

* change total active alerts to total active threat alerts

Signed-off-by: Joanne Wang <[email protected]>

* Add period to end of correlate events content

Signed-off-by: Joanne Wang <[email protected]>

* fix spacing and padding

Signed-off-by: Joanne Wang <[email protected]>

* make search and filters compressed

Signed-off-by: Joanne Wang <[email protected]>

* make search and filter compressed pt 2

Signed-off-by: Joanne Wang <[email protected]>

* move refresh and actions next to search bar

Signed-off-by: Joanne Wang <[email protected]>

* move bulk delete to left of search bar

Signed-off-by: Joanne Wang <[email protected]>

* fix spacing for detector details view

Signed-off-by: Joanne Wang <[email protected]>

* change content panel from h2 to h3

Signed-off-by: Joanne Wang <[email protected]>

* remove empty hover state

Signed-off-by: Joanne Wang <[email protected]>

* fix sizing for empty widget

Signed-off-by: Joanne Wang <[email protected]>

* fix heading spacing

Signed-off-by: Joanne Wang <[email protected]>

* change getting started to get started pt2

Signed-off-by: Joanne Wang <[email protected]>

* run yarn test:jest -u

Signed-off-by: Joanne Wang <[email protected]>

* add helper function for empty prompt and change to p instead of span

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit 9c0c2f4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Oct 3, 2024
* add plus sign to create detector button



* change getting started to get started



* run yarn test:jest -u



* move tabs to top



* remove duplicate code



* change total active alerts to total active threat alerts



* Add period to end of correlate events content



* fix spacing and padding



* make search and filters compressed



* make search and filter compressed pt 2



* move refresh and actions next to search bar



* move bulk delete to left of search bar



* fix spacing for detector details view



* change content panel from h2 to h3



* remove empty hover state



* fix sizing for empty widget



* fix heading spacing



* change getting started to get started pt2



* run yarn test:jest -u



* add helper function for empty prompt and change to p instead of span



---------


(cherry picked from commit 9c0c2f4)

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request Jan 9, 2025
…#1178)

* add plus sign to create detector button



* change getting started to get started



* run yarn test:jest -u



* move tabs to top



* remove duplicate code



* change total active alerts to total active threat alerts



* Add period to end of correlate events content



* fix spacing and padding



* make search and filters compressed



* make search and filter compressed pt 2



* move refresh and actions next to search bar



* move bulk delete to left of search bar



* fix spacing for detector details view



* change content panel from h2 to h3



* remove empty hover state



* fix sizing for empty widget



* fix heading spacing



* change getting started to get started pt2



* run yarn test:jest -u



* add helper function for empty prompt and change to p instead of span



---------


(cherry picked from commit 9c0c2f4)

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Jan 10, 2025
* feat: update category (#1169) (#1170)

(cherry picked from commit 8865ff1)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Bug fixes for threat intel, duplicate findings, and breadcrumbs path (#1176) (#1177)

* fix spacing for threat intel



* fix alienvault source details page crash



* fix threat intel findings widget view view all url crash



* fix security analtyics breadcrumbs link path crash



* fix duplicate findings



---------


(cherry picked from commit 0ce91fb)

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fit and Finish UX Fixes (#1174) (#1178)

* add plus sign to create detector button



* change getting started to get started



* run yarn test:jest -u



* move tabs to top



* remove duplicate code



* change total active alerts to total active threat alerts



* Add period to end of correlate events content



* fix spacing and padding



* make search and filters compressed



* make search and filter compressed pt 2



* move refresh and actions next to search bar



* move bulk delete to left of search bar



* fix spacing for detector details view



* change content panel from h2 to h3



* remove empty hover state



* fix sizing for empty widget



* fix heading spacing



* change getting started to get started pt2



* run yarn test:jest -u



* add helper function for empty prompt and change to p instead of span



---------


(cherry picked from commit 9c0c2f4)

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [Fit&Finish] Security analytics overview page (#1175) (#1179)

* fit&finish



* add width for recent threat alerts card



* fix typo



---------


(cherry picked from commit 076d1ef)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* avoid showing unuseful error toast when ds is not yet selected (#1186) (#1187)

(cherry picked from commit e4fdd25)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: Update getting started cards content and visual design (#1188) (#1189)

(cherry picked from commit 2b33ca2)

Signed-off-by: Viraj Sanghvi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* testing default ds switch changes (#1199) (#1201)

(cherry picked from commit 5d3801a)

Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* make dataSource default cluster for threat alerts card (#1200) (#1203)

(cherry picked from commit 48669ca)

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix data source picker for threat alerts card (#1206) (#1207)

* Fix data source picker for threat alerts card



* remove unused import



* fix get alerts loop



---------


(cherry picked from commit b2eb62c)

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* do not decode ds id from url; update global state on ds change (#1216) (#1217)

(cherry picked from commit ad76b7b)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Viraj Sanghvi <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants