[Fit&Finish] Security analytics overview page #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hailong-am
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
|
@amsiglan @riysaxen-amzn can you help to review this and add backport 2.x label? |
9 tasks
amsiglan
reviewed
Oct 7, 2024
| @@ -101,15 +103,17 @@ export const Overview: React.FC<OverviewProps> = (props) => { | |||
| () => new OverviewViewModelActor(saContext?.services, context?.notifications!), | |||
| [saContext?.services, context] | |||
| ); | |||
|
|
|||
| const currentNavGroup = useObservable(getChrome().navGroup.getCurrentNavGroup$()); | |||
| const isSecurityAnalyticsUesCase = currentNavGroup?.id === SECURITY_ANALYTICS_USE_CASE_ID; | |||
There was a problem hiding this comment.
Nit: typo
isSecurityAnalyticsUesCase
There was a problem hiding this comment.
thanks for catching this, updated.
amsiglan
approved these changes
Oct 7, 2024
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
AWSHurneyt
approved these changes
Oct 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
* fit&finish Signed-off-by: Hailong Cui <[email protected]> * add width for recent threat alerts card Signed-off-by: Hailong Cui <[email protected]> * fix typo Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 076d1ef) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Oct 10, 2024
* fit&finish * add width for recent threat alerts card * fix typo --------- (cherry picked from commit 076d1ef) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Analytics All use case
Security Analytics use case
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.