-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OUI Docs] Updated the logo to logoOpenSearch #315
[OUI Docs] Updated the logo to logoOpenSearch #315
Conversation
fee3a14
to
b8441aa
Compare
This might be blocked until we actually add the OpenSearch icon to OUI. Doesn't make sense having an empty icon on the doc site |
Signed-off-by: AbhishekReddy1127 <[email protected]>
b8441aa
to
de94597
Compare
For now, can we add it as a one-off SVG? I thought OUIicon allows for you to do that. |
I think dependency should just be denoted by a comment and blocked label. Just until we get the icon. I think we could just add it in a separate PR, as a one off thing like @kgcreative mentioned, but until then I don't think we should merge this one |
blocked by #369 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking PR has been merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: AbhishekReddy1127 <[email protected]> Co-authored-by: Sean Neumann <[email protected]> (cherry picked from commit aa2937e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: AbhishekReddy1127 <[email protected]> Co-authored-by: Sean Neumann <[email protected]> (cherry picked from commit aa2937e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: AbhishekReddy1127 <[email protected]> Co-authored-by: Sean Neumann <[email protected]> (cherry picked from commit aa2937e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit aa2937e) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Neumann <[email protected]>
(cherry picked from commit aa2937e) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Neumann <[email protected]>
(cherry picked from commit aa2937e) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Neumann <[email protected]>
Description
Updated the logoElastic to LogoOpensearch in the section A full page with evreything.
Issues Resolved
#177
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.