Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OUI Docs) Page #177

Open
1 of 2 tasks
Tracked by #112
KrooshalUX opened this issue Dec 30, 2022 · 5 comments · Fixed by #315
Open
1 of 2 tasks
Tracked by #112

(OUI Docs) Page #177

KrooshalUX opened this issue Dec 30, 2022 · 5 comments · Fixed by #315
Labels

Comments

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Dec 30, 2022

Section: A full page with everything

  • Check the routing for the Exit Full Screen button - I a not sure if we are going to run into this issue once we move versions - it does not appear to work cross-version. (To replicate the issue, visit https://eui.elastic.co/v34.6.0/#/layout/page, click Go full screen, then click exit full screen.)

  • Update all references of logoElastic to logoOpenSearch (The logoOpenSearch has not yet been uploaded and is part of issue (OUI Docs) Icons #248 )

@KrooshalUX KrooshalUX changed the title Page (OUI Docs) Page Dec 30, 2022
@BSFishy
Copy link
Contributor

BSFishy commented Jan 4, 2023

The latest version of OUI does not have the first problem that you mentioned. Checked it off.

@BSFishy BSFishy added the documentation Improvements or additions to documentation label Jan 12, 2023
@KrooshalUX KrooshalUX added OUIDocs v2.6.0 and removed documentation Improvements or additions to documentation labels Jan 12, 2023
@KrooshalUX KrooshalUX linked a pull request Feb 21, 2023 that will close this issue
6 tasks
@joshuarrrr joshuarrrr reopened this Mar 23, 2023
@joshuarrrr
Copy link
Member

Not all tasks completed

@joshuarrrr
Copy link
Member

@KrooshalUX The task is not marked off but the linked issue is closed. Can you confirm if there's remaining work to be done here?

@KrooshalUX
Copy link
Contributor Author

This is a little complicated at this point... the issue getting closed without the work being fully done lead to this issue that I believe there is already a PR against:
#622

however, I realized after the fact that we don't use icons in our page titles, so I have created this follow up item: #625

@ashwin-pc
Copy link
Member

@KrooshalUX can we then update the description of the issue to indicate what the criteria to close this is? because as it stands its unclear why this issue is still open even though all the taks in the description have been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants