-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oui docs - headers page changes #109
oui docs - headers page changes #109
Conversation
ffc6146
to
7d03b57
Compare
…ducts and apps Signed-off-by: Kroosh <[email protected]>
8149ab4
to
2706d23
Compare
Signed-off-by: Kristen Crusius <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have some logos to update
Signed-off-by: Kroosh Crusius [email protected]
@BSFishy my mistake - somehow only committed one file instead of all of them. This has now been updated and is now available for your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to keep passing this back, but linter issues should be fixed before merging
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
@KrooshalUX This is missing a signoff for some of the commits, can you squash the commits and push the changes again? |
* Changes for style and inclusivity, removes references to outdated products and apps Signed-off-by: Kroosh <[email protected]> * Changed logoOUI to logoOpenSearch Signed-off-by: Kristen Crusius <[email protected]> * Update header_elastic_pattern.js * Update header_links.js * Update header_position.js * Update header_sections.js * Update header_stacked.js Signed-off-by: Kroosh Crusius [email protected] * Update header_position.js Signed-off-by: Matt Provost <[email protected]> * Update header_position.js Signed-off-by: Matt Provost <[email protected]> * Update header_stacked.js Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Kroosh <[email protected]> Signed-off-by: Kristen Crusius <[email protected]> Signed-off-by: Kroosh Crusius [email protected] Signed-off-by: Matt Provost <[email protected]> Co-authored-by: Matt Provost <[email protected]> Co-authored-by: Sean Neumann <[email protected]> Co-authored-by: Matt Provost <[email protected]> (cherry picked from commit fac9770) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Changes for style and inclusivity, removes references to outdated products and apps * Changed logoOUI to logoOpenSearch * Update header_elastic_pattern.js * Update header_links.js * Update header_position.js * Update header_sections.js * Update header_stacked.js Signed-off-by: Kroosh Crusius [email protected] * Update header_position.js * Update header_position.js * Update header_stacked.js --------- Signed-off-by: Kroosh Crusius [email protected] (cherry picked from commit fac9770) Signed-off-by: Kroosh <[email protected]> Signed-off-by: Kristen Crusius <[email protected]> Signed-off-by: Kroosh Crusius [email protected] Signed-off-by: Matt Provost <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Provost <[email protected]> Co-authored-by: Sean Neumann <[email protected]> Co-authored-by: Matt Provost <[email protected]>
Signed-off-by: Kroosh Crusius [email protected]
Description
Edits to the Header documentation within OUI. These changes include removing references to products no longer relevant to the OpenSearch project.
Issues Resolved
#110
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.