Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oui docs - headers page changes #109

Merged
merged 17 commits into from
Mar 7, 2023

Conversation

KrooshalUX
Copy link
Contributor

@KrooshalUX KrooshalUX commented Nov 4, 2022

Signed-off-by: Kroosh Crusius [email protected]

Description

Edits to the Header documentation within OUI. These changes include removing references to products no longer relevant to the OpenSearch project.

Issues Resolved

#110

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@KrooshalUX KrooshalUX changed the title changes username for inclusivity oui docs - headers page changes Nov 4, 2022
@BSFishy BSFishy marked this pull request as ready for review January 23, 2023 22:28
@BSFishy BSFishy requested a review from a team as a code owner January 23, 2023 22:28
Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have some logos to update

src-docs/src/views/header/header_elastic_pattern.js Outdated Show resolved Hide resolved
src-docs/src/views/header/header_links.js Outdated Show resolved Hide resolved
src-docs/src/views/header/header_position.js Outdated Show resolved Hide resolved
src-docs/src/views/header/header_sections.js Outdated Show resolved Hide resolved
src-docs/src/views/header/header_stacked.js Outdated Show resolved Hide resolved
@KrooshalUX KrooshalUX requested a review from BSFishy March 2, 2023 00:16
@KrooshalUX
Copy link
Contributor Author

@BSFishy my mistake - somehow only committed one file instead of all of them. This has now been updated and is now available for your review

Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to keep passing this back, but linter issues should be fixed before merging

@ashwin-pc
Copy link
Member

@KrooshalUX This is missing a signoff for some of the commits, can you squash the commits and push the changes again?

@BSFishy BSFishy merged commit fac9770 into opensearch-project:main Mar 7, 2023
BSFishy added a commit that referenced this pull request Mar 7, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 7, 2023
* Changes for style and inclusivity, removes references to outdated products and apps

Signed-off-by: Kroosh <[email protected]>

* Changed logoOUI to logoOpenSearch

Signed-off-by: Kristen Crusius <[email protected]>

* Update header_elastic_pattern.js

* Update header_links.js

* Update header_position.js

* Update header_sections.js

* Update header_stacked.js

Signed-off-by: Kroosh Crusius [email protected]

* Update header_position.js

Signed-off-by: Matt Provost <[email protected]>

* Update header_position.js

Signed-off-by: Matt Provost <[email protected]>

* Update header_stacked.js

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Kroosh <[email protected]>
Signed-off-by: Kristen Crusius <[email protected]>
Signed-off-by: Kroosh Crusius [email protected]
Signed-off-by: Matt Provost <[email protected]>
Co-authored-by: Matt Provost <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
Co-authored-by: Matt Provost <[email protected]>
(cherry picked from commit fac9770)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@KrooshalUX KrooshalUX mentioned this pull request Mar 7, 2023
6 tasks
joshuarrrr pushed a commit that referenced this pull request Mar 9, 2023
* Changes for style and inclusivity, removes references to outdated products and apps



* Changed logoOUI to logoOpenSearch



* Update header_elastic_pattern.js

* Update header_links.js

* Update header_position.js

* Update header_sections.js

* Update header_stacked.js

Signed-off-by: Kroosh Crusius [email protected]

* Update header_position.js



* Update header_position.js



* Update header_stacked.js



---------



Signed-off-by: Kroosh Crusius [email protected]




(cherry picked from commit fac9770)

Signed-off-by: Kroosh <[email protected]>
Signed-off-by: Kristen Crusius <[email protected]>
Signed-off-by: Kroosh Crusius [email protected]
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Provost <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
Co-authored-by: Matt Provost <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants