-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(OUI Docs) Docs Site Header #111
Comments
Hi @KrooshalUX Thanks for creating this issue. I need more information on 5th task. When you say |
@bandinib-amzn this is meant to just update the reference away from elastic to oui. This will create a reference to a broken image, I need to commit my logo change which will resolve this. |
Thanks @KrooshalUX clarification. So will it be fine to raise a PR which create a reference to a broken image? Should I wait for your logo change and we can work in parallel ? |
Also we have |
Re: I can make a commit with a the temporary logo once I land tomorrow, I am away from my computer for the day. Re: other logos (including logoTimelion etc) I am changing those as I come across them - I am tracking per page. |
That would be absolutely fine @KrooshalUX. I am just asking questions here so that I can keep track of those. It can wait till tomorrow. |
@AbhishekReddy1127 just a quick update - the find-replace that was done for Elastic to OUI incorrectly prescribed to change |
Re-opening: The PR #109 didn't address the last bullet point to remove the Elastic logo. @BSFishy @AbhishekReddy1127 can someone take a look ? |
These changes are necessary before go live:
The text was updated successfully, but these errors were encountered: