Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OUI Docs) Docs Site Header #111

Closed
6 tasks done
Tracked by #112
KrooshalUX opened this issue Nov 5, 2022 · 8 comments · Fixed by #164 or #579
Closed
6 tasks done
Tracked by #112

(OUI Docs) Docs Site Header #111

KrooshalUX opened this issue Nov 5, 2022 · 8 comments · Fixed by #164 or #579
Assignees
Labels

Comments

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Nov 5, 2022

These changes are necessary before go live:

  • Remove Figma link/icon
  • Remove Codesandbox link/icon
  • Remove Cascadia options (Cascadia: Light, Cascadia: Dark) from theme dropdown
  • Remove Babelfish (comment out pending further testing and localization strategy)
  • Change logoElastic to logoOpenSearch
  • Replace favicon with OpenSearch favicon
@bandinib-amzn
Copy link
Member

Hi @KrooshalUX

Thanks for creating this issue. I need more information on 5th task. When you say Change logoElastic to logoOUI, do you mean that replace the text logoElastic with logoOUI in code or change below icon in header?
Screen Shot 2022-11-08 at 3 38 39 PM

@KrooshalUX
Copy link
Contributor Author

@bandinib-amzn this is meant to just update the reference away from elastic to oui. This will create a reference to a broken image, I need to commit my logo change which will resolve this.

@bandinib-amzn
Copy link
Member

@bandinib-amzn this is meant to just update the reference away from elastic to oui. This will create a reference to a broken image, I need to commit my logo change which will resolve this.

Thanks @KrooshalUX clarification. So will it be fine to raise a PR which create a reference to a broken image? Should I wait for your logo change and we can work in parallel ?

@bandinib-amzn
Copy link
Member

Also we have logoElasticsearch and logoElasticStack in some files. Should we also change those?

@KrooshalUX
Copy link
Contributor Author

@bandinib-amzn :

Re: I can make a commit with a the temporary logo once I land tomorrow, I am away from my computer for the day.

Re: other logos (including logoTimelion etc) I am changing those as I come across them - I am tracking per page.

@bandinib-amzn
Copy link
Member

tomorrow, I am away from my computer for the day.

That would be absolutely fine @KrooshalUX. I am just asking questions here so that I can keep track of those. It can wait till tomorrow.

@KrooshalUX
Copy link
Contributor Author

@AbhishekReddy1127 just a quick update - the find-replace that was done for Elastic to OUI incorrectly prescribed to change logoElastic to logoOUI when the change should have been to logoOpensearch. Updated in the issue description and will update in other issues where logoOUI now appears after the early changes that the previous engineering team did a find-replace.

@KrooshalUX
Copy link
Contributor Author

KrooshalUX commented Mar 7, 2023

Re-opening: The PR #109 didn't address the last bullet point to remove the Elastic logo. @BSFishy @AbhishekReddy1127 can someone take a look ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants