Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalise model_id requirements in SentenceTransformerModel #381

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Rationalise model_id requirements in SentenceTransformerModel #381

wants to merge 8 commits into from

Commits on Feb 23, 2024

  1. refactor: use self.model_id where applicable 

    Signed-off-by: Jean-Baptiste Oger <[email protected]>
    @Jebq
    Jebq authored and Jean-Baptiste Oger committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f6ae513 View commit details
    Browse the repository at this point in the history

  2. doc: update CHANGELOG 

    Signed-off-by: Jean-Baptiste Oger <[email protected]>
    @Jebq
    Jebq authored and Jean-Baptiste Oger committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    4551904 View commit details
    Browse the repository at this point in the history

  3. lint 

    Signed-off-by: Jean-Baptiste Oger <[email protected]>
    @Jebq
    Jebq authored and Jean-Baptiste Oger committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    ee7b3d1 View commit details
    Browse the repository at this point in the history

  4. test: update tests 

    Signed-off-by: Jean-Baptiste Oger <[email protected]>
    @Jebq
    Jebq authored and Jean-Baptiste Oger committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b2bc31e View commit details
    Browse the repository at this point in the history

  5. test: fix test_save_as_pt_model_with_different_id 

    Signed-off-by: Jean-Baptiste Oger <[email protected]>
    Jean-Baptiste Oger committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    6c1e476 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Merge branch 'main' into sentencetransformers-model-id 

    Signed-off-by: Jebq <[email protected]>
    @Jebq
    Jebq authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    1f8f615 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Update CHANGELOG.md 

    Signed-off-by: Jebq <[email protected]>
    @Jebq
    Jebq authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    c58e75b View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. fix: use model_id instead of self.model_id when output_model_name is … 

    …None in train_model

Signed-off-by: Jean-Baptiste Oger <[email protected]>
    Jean-Baptiste Oger committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    12e6351 View commit details
    Browse the repository at this point in the history