-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rationalise model_id requirements in SentenceTransformerModel #381
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jean-Baptiste Oger <[email protected]>
Signed-off-by: Jean-Baptiste Oger <[email protected]>
Signed-off-by: Jean-Baptiste Oger <[email protected]>
Signed-off-by: Jean-Baptiste Oger <[email protected]>
Signed-off-by: Jean-Baptiste Oger <[email protected]>
Signed-off-by: Jebq <[email protected]>
Signed-off-by: Jebq <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 91.53% 91.54% +0.01%
==========================================
Files 42 42
Lines 4395 4401 +6
==========================================
+ Hits 4023 4029 +6
Misses 372 372 ☔ View full report in Codecov by Sentry. |
…None in train_model Signed-off-by: Jean-Baptiste Oger <[email protected]>
91c7396
to
12e6351
Compare
Description
This PR is mainly intended at removing the requirements for
model_id
arg when serializing aSentenceTransformerModel
(both torch and onnx).It also adds an argument in
make_model_config_json
to allow an user to provide a path where the json should be saved.Issues Resolved
#323
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.