Add a new Jenkins job for the smoke test #5225
Conversation
Signed-off-by: Zelin Hao <[email protected]>
zelinh
requested review from
dblock,
peterzhuamazon,
gaiksaya,
rishabh6788,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
| stash includes: '**', name: "smoketest-opensearch-$BUILD_NUMBER" | ||
|
|
||
| timeout(time: 1, unit: 'HOURS') { | ||
| node(AGENT_LABEL) { |
There was a problem hiding this comment.
Is this similar to integTest where each plugin will have its own container?
There was a problem hiding this comment.
Not exactly. All testing plugins would be tested with only one deployed container.
There was a problem hiding this comment.
You mean all plugins would run sequentially one after the other?
There was a problem hiding this comment.
So far yes. All tests should be lightweight.
Signed-off-by: Zelin Hao <[email protected]>
| def docker_images = [ | ||
| 'tar': 'opensearchstaging/ci-runner:ci-runner-al2-opensearch-build-v1', | ||
| 'rpm': 'opensearchstaging/ci-runner:ci-runner-almalinux8-systemd-base-integtest-v1', | ||
| 'deb': 'opensearchstaging/ci-runner:ci-runner-ubuntu2004-systemd-base-integtest-v3', | ||
| 'zip': 'opensearchstaging/ci-runner:ci-runner-windows2019-opensearch-build-v1', | ||
| ] |
There was a problem hiding this comment.
Looks like we need to add these docker images sooner as workflows are increasing. #4233
| stash includes: '**', name: "smoketest-opensearch-$BUILD_NUMBER" | ||
|
|
||
| timeout(time: 1, unit: 'HOURS') { | ||
| node(AGENT_LABEL) { |
There was a problem hiding this comment.
You mean all plugins would run sequentially one after the other?
zelinh
force-pushed
the
smoke-test-test
branch
3 times, most recently
from
c342946 to
d9e1e0e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5225 +/- ##
==========================================
- Coverage 92.35% 92.12% -0.24%
==========================================
Files 197 202 +5
Lines 6814 7033 +219
==========================================
+ Hits 6293 6479 +186
- Misses 521 554 +33 ☔ View full report in Codecov by Sentry. |
| try { | ||
| stage("Smoke_tests") { | ||
| checkout scm | ||
| sleep 20 |
There was a problem hiding this comment.
Why do we need sleep here?
There was a problem hiding this comment.
I'm thinking it may need time for the job to checkout source code
Signed-off-by: Zelin Hao <[email protected]>
zelinh
force-pushed
the
smoke-test-test
branch
from
d9e1e0e to
df2d013
Compare
Signed-off-by: Zelin Hao <[email protected]>
| docker.withRegistry('https://public.ecr.aws/') { | ||
| docker.image(docker_images["$distribution"]).inside(docker_args["$distribution"]) { |
There was a problem hiding this comment.
Maybe we should just switch to the pipeline standard:
https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L157C21-L164C22
Since you just need one runner and you just need 2+ minutes to run all the plugins.
Also suggest to set the timeout at the job level and set it to 30min instead of 1 hour. Thanks.
There was a problem hiding this comment.
So far we only onboard opensearch core component and it takes around 2-3 minutes for smoke tests. We would expect some additional time when more components coming in. I think we set it to 1 hour to be safe for now and may see how it goes in future.
I will update the pipeline for agent & docker as suggested here. Thanks!
There was a problem hiding this comment.
Updated in the latest commit. Thanks!
Signed-off-by: Zelin Hao <[email protected]>
Description
Add a new jenkinsfile for the smoke test Jenkins job intended for CI with distribution build job.
Issues Resolved
Part of #5224
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.