Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor release-notes workflow #4627

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Refactor release-notes workflow #4627

merged 2 commits into from
Apr 11, 2024

Conversation

rishabh6788
Copy link
Collaborator

@rishabh6788 rishabh6788 commented Apr 11, 2024 •
edited
Loading

Description

This PR:

  • Fixes bug to also include core components while checking and compiling release notes.
  • Adds feature to check and compile release notes for OpenSearch + components and OpenSearch Dashboards + components in a single run.
  • Converts the html format back to markdown.

Issues Resolved

#4549 #4504

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rishabh6788
Copy link
Collaborator Author

rishabh6788 commented Apr 11, 2024 •
edited
Loading

Attached sample release-notes for OS and OSD combined.
@gaiksaya @peterzhuamazon

release_notes-2.13.0.md

peterzhuamazon
peterzhuamazon reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rishabh6788 ,

Have some comments about the PR.

Thanks.

src/release_notes_workflow/release_notes.py Show resolved Hide resolved
src/run_releasenotes_check.py Show resolved Hide resolved
src/run_releasenotes_check.py Show resolved Hide resolved
src/run_releasenotes_check.py Show resolved Hide resolved
src/run_releasenotes_check.py Show resolved Hide resolved
@peterzhuamazon
Copy link
Member

Mend show issues with this cve:

[CVE-2024-22949](https://www.mend.io/vulnerability-database/CVE-2024-22949)
	Medium 	5.5 	jfreechart-1.0.19.jar 		None

@rishabh6788
Copy link
Collaborator Author

Mend show issues with this cve:

[CVE-2024-22949](https://www.mend.io/vulnerability-database/CVE-2024-22949)
	Medium 	5.5 	jfreechart-1.0.19.jar 		None

I think this is coming from jenkins core.

@rishabh6788
Refactor release-notes workflow
23880a0 
Signed-off-by: Rishabh Singh <[email protected]>
peterzhuamazon
peterzhuamazon approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rishabh6788 , approved!

@rishabh6788 rishabh6788 merged commit 4fc22c5 into opensearch-project:main Apr 11, 2024
10 checks passed
@rishabh6788 rishabh6788 mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhuamazon peterzhuamazon peterzhuamazon approved these changes

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@bbarani bbarani Awaiting requested review from bbarani

@gaiksaya gaiksaya Awaiting requested review from gaiksaya gaiksaya is a code owner

@zelinh zelinh Awaiting requested review from zelinh zelinh is a code owner

@jordarlu jordarlu Awaiting requested review from jordarlu

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@Divyaasm Divyaasm Awaiting requested review from Divyaasm Divyaasm is a code owner

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

Assignees
No one assigned
Labels
distinguished-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishabh6788 @peterzhuamazon @gaiksaya