Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Release notes checker does not check release notes for core engines #4549

Closed
gaiksaya opened this issue Mar 21, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@gaiksaya
Copy link
Member

Describe the bug

With recent enhancement to compile consolidated release notes PR, a change was introduced to skip few components here

However, we do not add core engine (OpenSearch and OpenSearch-Dashboards) release notes, we do however need to check their presence in release notes tracker workflow that posts the comments on the release issue.
Example: #4433 (comment)

To reproduce

See #4433 (comment)

Expected behavior

The table should also component: OpenSearch and OpenSearch-Dashboards.

The condition is true for action_type: compile but theaction_type: check should only skip notifications-core and not others

Screenshots

If applicable, add screenshots to help explain your problem.

Host / Environment

No response

Additional context

No response

Relevant log output

No response

@gaiksaya gaiksaya added bug Something isn't working untriaged Issues that have not yet been triaged labels Mar 21, 2024
@rishabh6788
Copy link
Collaborator

Will take a look.

@rishabh6788 rishabh6788 self-assigned this Apr 1, 2024
@rishabh6788 rishabh6788 removed the untriaged Issues that have not yet been triaged label Apr 1, 2024
@gaiksaya
Copy link
Member Author

gaiksaya commented Apr 1, 2024

One more thing,
There is another bug let me know if I should create a different issue for the same.
The consolidated release notes adds ml-commons as ml-common and Opensearch should be OpenSearch in all headings. Somehow this is getting messed up. Example: 7b2352e

@rishabh6788
Copy link
Collaborator

One more thing, There is another bug let me know if I should create a different issue for the same. The consolidated release notes adds ml-commons as ml-common and Opensearch should be OpenSearch in all headings. Somehow this is getting messed up. Example: 7b2352e

These seems minor nits, lets track in another issue.
Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants