Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding K-NN in 3.0.0 manifest and geospatial in 2.4 and 3.0 manifests. #2675

Closed
wants to merge 1 commit into from
Closed

Adding K-NN in 3.0.0 manifest and geospatial in 2.4 and 3.0 manifests. #2675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions manifests/2.4.0/opensearch-2.4.0.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,11 @@ components:
checks:
- gradle:properties:version
- gradle:dependencies:opensearch.version
- name: geospatial
repository: https://github.com/opensearch-project/geospatial.git
ref: '2.x'
platforms:
- linux
Comment on lines +89 to +90
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would need to add windows platform for 2.4 manifest as windows distribution is planned to released in this version. @peterzhuamazon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the groovy failure might not relate to this tho.

checks:
- gradle:properties:version
- gradle:dependencies:opensearch.version
16 changes: 16 additions & 0 deletions manifests/3.0.0/opensearch-3.0.0.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,19 @@ components:
checks:
- gradle:properties:version
- gradle:dependencies:opensearch.version
- name: geospatial
repository: https://github.com/opensearch-project/geospatial.git
ref: main
platforms:
- linux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add windows here as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only add for geospatial leave knn linux only.

checks:
- gradle:properties:version
- gradle:dependencies:opensearch.version
- name: k-NN
repository: https://github.com/opensearch-project/k-NN.git
ref: main
platforms:
- linux
checks:
- gradle:properties:version
- gradle:dependencies:opensearch.version