Adding K-NN in 3.0.0 manifest and geospatial in 2.4 and 3.0 manifests. #2675
Conversation
Signed-off-by: Navneet Verma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2675 +/- ##
=======================================
Coverage 94.24% 94.24%
=======================================
Files 162 162
Lines 4313 4313
Branches 19 19
=======================================
Hits 4065 4065
Misses 248 248 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| platforms: | ||
| - linux |
There was a problem hiding this comment.
I think we would need to add windows platform for 2.4 manifest as windows distribution is planned to released in this version. @peterzhuamazon
There was a problem hiding this comment.
Also the groovy failure might not relate to this tho.
| repository: https://github.com/opensearch-project/geospatial.git | ||
| ref: main | ||
| platforms: | ||
| - linux |
There was a problem hiding this comment.
Please add windows here as well.
There was a problem hiding this comment.
Only add for geospatial leave knn linux only.
|
@navneet1v , could you rebase your repo with opensearch-build@main and rerun the validation? it seems like your repo is out dated with the opensearch-build@main; hence, groovy test was fail. Thanks. |
|
I can see that @naveentatikonda has raised another PR for the same and it got merged. 6b71a5f Closing this PR. |
Description
Adding K-NN in 3.0.0 manifest and geospatial in 2.4 and 3.0 manifests.
Signed-off-by: Navneet Verma [email protected]
Issues Resolved
opensearch-project/geospatial#94
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.