Make sure notifications is built correctly while passing ci checks #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
1 task
Codecov Report
@@ Coverage Diff @@
## main #1959 +/- ##
=========================================
Coverage 94.46% 94.46%
Complexity 22 22
=========================================
Files 179 179
Lines 3649 3649
Branches 29 29
=========================================
Hits 3447 3447
Misses 196 196
Partials 6 6 Continue to review full report at Codecov.
|
CEHENKLE
approved these changes
Apr 13, 2022
This was referenced Apr 13, 2022
1 task
bbarani
approved these changes
Apr 13, 2022
|
This looks problematic to me because it will stop working if we move the scripts to the notifications repo, which will be required so that we can make changes across multiple versions. So this is a time bomb that will hit us in version 2.x. This was done correctly in #1957 and opensearch-project/notifications#403. The CI check is not that important. I guess we can leave it like this now, this is just another hack on top of the fact that notifications-core even exists. |
prudhvigodithi
pushed a commit
to prudhvigodithi/opensearch-build
that referenced
this pull request
Apr 13, 2022
…arch-project#1947) Signed-off-by: Sagar Upadhyaya <[email protected]> Adding code block for maven plugin zips Signed-off-by: pgodithi <[email protected]> Adding code block for maven plugin zips Signed-off-by: pgodithi <[email protected]> zip maven publish Signed-off-by: pgodithi <[email protected]> added zipsmaven dir check Signed-off-by: pgodithi <[email protected]> Adding better gradle project dir Signed-off-by: pgodithi <[email protected]> test maven snapshots Signed-off-by: pgodithi <[email protected]> test maven snapshots Signed-off-by: pgodithi <[email protected]> test maven snapshots Signed-off-by: pgodithi <[email protected]> test maven snapshots Signed-off-by: pgodithi <[email protected]> test maven snapshots Signed-off-by: pgodithi <[email protected]> test maven snapshots Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> Removing build script for PA (opensearch-project#1952) Signed-off-by: Sagar Upadhyaya <[email protected]> update release issue with steps to update ansible and helm (opensearch-project#1942) * update release issue with steps to update ansible and helm Signed-off-by: Abhinav Gupta <[email protected]> * updated test as sample PR Signed-off-by: Abhinav Gupta <[email protected]> * adding periods Signed-off-by: Abhinav Gupta <[email protected]> Fix the path for maven sign and staging job (opensearch-project#1954) * Fix the path for staging maven Signed-off-by: Zelin Hao <[email protected]> * Add the distribution folder tar to the artifact path and update test Signed-off-by: Zelin Hao <[email protected]> [OSD][2.0.0] use rc1 qualifier (opensearch-project#1949) Signed-off-by: Kawika Avilla <[email protected]> install createrepo in docker image for RPM yum repo support (opensearch-project#1955) * install createrepo in docker image for RPM yum repo support Signed-off-by: Tianle Huang <[email protected]> * fix Signed-off-by: Tianle Huang <[email protected]> * update opensearch to use new image Signed-off-by: Tianle Huang <[email protected]> Add systemd docker for rpm service test (opensearch-project#1958) * Add systemd based image for yum install testing and more Signed-off-by: Peter Zhu <[email protected]> * More packages to add to the images Signed-off-by: Peter Zhu <[email protected]> lower freq for build for 1.3.1 opensearch-dashboards (opensearch-project#1941) * lower freq for build for 1.3.1 opensearch-dashboards Signed-off-by: Abhinav Gupta <[email protected]> * removed build for 1.2.x and 1.3.1 Signed-off-by: Abhinav Gupta <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> Added notifications-core and notifications to 2.0 and add integTest manifest (opensearch-project#1957) * Added notifications-core and notifications to 2.0. Signed-off-by: dblock <[email protected]> * Remove scripts from opensearch-build. Signed-off-by: dblock <[email protected]> * Remove dashboards notifications scripts to use the default one Signed-off-by: Peter Zhu <[email protected]> * Remove CI checks for lack of gradlew. Signed-off-by: dblock <[email protected]> * Fix the second subfolder location after core Signed-off-by: Peter Zhu <[email protected]> * Add notifications related build scripts to build repo Signed-off-by: Peter Zhu <[email protected]> * Tweak build scripts to correctly move the zips Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Make sure notifications is built correctly while passing ci checks (opensearch-project#1959) Signed-off-by: Peter Zhu <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]> test snapshot build Signed-off-by: pgodithi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu [email protected]
Description
Make sure notifications is built correctly while passing ci checks
Issues Resolved
#1950
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.