Added notifications-core and notifications to 2.0 and add integTest manifest

[dblock]

Signed-off-by: dblock [email protected]

Description

Simpler alternative to #1956. Requires opensearch-project/notifications#403

Issues Resolved

Closes #1950.

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[peterzhuamazon]

As discussed in #1956 we will go with #1957 for now.
This allows us to use existing code base and functionalities to resolve the problem without changing too much for this specific use case.

Thanks.

[dblock]

CI was failing on checks because it tries to execute ./gradlew in notiications/core which doesn't exist. I just removed the checks for now. Really notifications/core feels like a very weird hack all around.

[codecov-commenter]

Codecov Report

Merging #1957 (a362984) into main (8522a31) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1957   +/-   ##
=========================================
  Coverage     94.46%   94.46%           
  Complexity       22       22           
=========================================
  Files           179      179           
  Lines          3649     3649           
  Branches         29       29           
=========================================
  Hits           3447     3447           
  Misses          196      196           
  Partials          6        6           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8522a31...a362984. Read the comment docs.

[peterzhuamazon]

I have tweaked the build.sh so it will build correctly now.

[peterzhuamazon]

This will go in with another PR: opensearch-project/notifications#404

[peterzhuamazon]

Seems like notifications due to name field is not matching the repo name of notifications.
It is better to save the build scripts in build repo not notifications repo.

[dblock]

Seems like notifications due to name field is not matching the repo name of notifications.

I don't think so. The check for notifications-core just failed with gradlew being not found, because there's none in notifications/core. Build works because we have notifications/core/scripts.

It is better to save the build scripts in build repo not notifications repo.

Build scripts change version-to-version, so they need to be different and follow notifications branching. If you leave them in opensearch-build with these changes, 1.3.x will start failing.

[peterzhuamazon]

Block for a bit as we are still fixing the build scripts.
Due to the double subfolder structure of notifications the builds folder and plugins are not correctly copied to tar/builds/opensearch/plugins.

We have fixed the issues for now and build script can correctly find the builds folder.

[gaiksaya]

@peterzhuamazon Can we add the checks back or are they still failing?

[peterzhuamazon]

@peterzhuamazon Can we add the checks back or are they still failing?

They will not pass as notifications structure is different from any other repos.

They need to build within notifications folder, but working directory is pointing to notifications/core and notifications/notifications and those two folders does not have gradle wrapper to run the tests.

[peterzhuamazon]

@gaiksaya fixed in #1959