Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location in bundle manifest and update artifacts upload logic #1944

Merged
merged 15 commits into from
Apr 8, 2022

Conversation

tianleh
Copy link
Member

@tianleh tianleh commented Apr 8, 2022

Description

We notice that the location field of bundle manifest has wrong url where distribution string is doubled. (after https://github.com/opensearch-project/opensearch-build/pull/1807/files is merged)

E.g download this file https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/3.0.0/2004/linux/arm64/rpm/dist/opensearch/manifest.yml

Screen Shot 2022-04-07 at 9 12 57 PM

Also the artifact promotion logic needs to have a distribution in the path. Per @peterzhuamazon 's suggestion, we rename the file to promoteTarArtifacts for clarity.

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

tianleh added 8 commits April 8, 2022 02:01
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
@tianleh tianleh requested a review from a team as a code owner April 8, 2022 04:14
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #1944 (cbb5366) into main (1116d3b) will increase coverage by 5.54%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #1944      +/-   ##
=============================================
+ Coverage     94.45%   100.00%   +5.54%     
=============================================
  Files           179         6     -173     
  Lines          3645       105    -3540     
  Branches         29        19      -10     
=============================================
- Hits           3443       105    -3338     
+ Misses          196         0     -196     
+ Partials          6         0       -6     
Impacted Files Coverage Δ
src/jenkins/BuildManifest.groovy
tests/jenkins/jobs/BuildManifest_Jenkinsfile
tests/jenkins/jobs/PromoteArtifacts_Jenkinsfile
...PromoteArtifacts_OpenSearch_Dashboards_Jenkinsfile
.../jenkins/jobs/PromoteArtifacts_actions_Jenkinsfile
...rtifacts_actions_OpenSearch_Dashboards_Jenkinsfile
src/manifests_workflow/manifests_args.py
src/ci_workflow/ci_check_list.py
src/paths/tree_walker.py
src/assemble_workflow/bundle_opensearch.py
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1116d3b...cbb5366. Read the comment docs.

tianleh added 5 commits April 8, 2022 04:54
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
@gaiksaya
Copy link
Member

gaiksaya commented Apr 8, 2022

Hi @tianleh This will be breaking change for website too right? Do we need to create an issue with website repo to let me know this? Also are we planing to backport other versions in /tar folder too?

@tianleh
Copy link
Member Author

tianleh commented Apr 8, 2022

Hi @tianleh This will be breaking change for website too right? Do we need to create an issue with website repo to let me know this? Also are we planing to backport other versions in /tar folder too?

I think the official announcement will be part of the overall RPM launch. As far as I know, no plan to backfill. cc @bbarani @peterzhuamazon

@tianleh
Copy link
Member Author

tianleh commented Apr 8, 2022

Hi @tianleh This will be breaking change for website too right? Do we need to create an issue with website repo to let me know this? Also are we planing to backport other versions in /tar folder too?

For the website, we are not changing the logic to production url. We only change the staging CI url.

@peterzhuamazon peterzhuamazon merged commit 69ad812 into opensearch-project:main Apr 8, 2022
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Apr 15, 2022
Location of artifacts was updated here:
opensearch-project/opensearch-build#1944

Updating the CLI for the out of the box experience with the same
warning as before:

At the time that this is committed there is no gurantee
that the latest build is the build that was select as the
final build.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit to opensearch-project/OpenSearch-Dashboards that referenced this pull request Apr 15, 2022
Location of artifacts was updated here:
opensearch-project/opensearch-build#1944

Updating the CLI for the out of the box experience with the same
warning as before:

At the time that this is committed there is no gurantee
that the latest build is the build that was select as the
final build.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants