-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix location in bundle manifest and update artifacts upload logic #1944
Conversation
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Tested in my Jenkins job Verify that the url no longer has double distribution strings. |
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Hi @tianleh This will be breaking change for website too right? Do we need to create an issue with website repo to let me know this? Also are we planing to backport other versions in |
I think the official announcement will be part of the overall RPM launch. As far as I know, no plan to backfill. cc @bbarani @peterzhuamazon |
For the |
Location of artifacts was updated here: opensearch-project/opensearch-build#1944 Updating the CLI for the out of the box experience with the same warning as before: At the time that this is committed there is no gurantee that the latest build is the build that was select as the final build. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
Location of artifacts was updated here: opensearch-project/opensearch-build#1944 Updating the CLI for the out of the box experience with the same warning as before: At the time that this is committed there is no gurantee that the latest build is the build that was select as the final build. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
Description
We notice that the location field of bundle manifest has wrong url where distribution string is doubled. (after https://github.com/opensearch-project/opensearch-build/pull/1807/files is merged)
E.g download this file https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/3.0.0/2004/linux/arm64/rpm/dist/opensearch/manifest.yml
Also the artifact promotion logic needs to have a distribution in the path. Per @peterzhuamazon 's suggestion, we rename the file to
promoteTarArtifacts
for clarity.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.