Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AD and Alerting to the manifest 2.0.0 and remove CU/Alerting build script #1878

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Mar 31, 2022

Signed-off-by: Peter Zhu [email protected]

Description

Add AD and Alerting to the manifest 2.0.0 and remove CU/Alerting build script

Corresponding changes:
opensearch-project/common-utils#152
opensearch-project/alerting#377

Issues Resolved

Part of #1624

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterzhuamazon
Copy link
Member Author

Hold this for a bit before merge.

@amitgalitz
Copy link
Member

amitgalitz commented Mar 31, 2022

@peterzhuamazon AD is experiencing issue on run still right now, CI is passing but this should maybe wait before merging opensearch-project/anomaly-detection#482

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

Merging #1878 (05050ad) into main (15c4f5d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1878   +/-   ##
=========================================
  Coverage     94.54%   94.54%           
  Complexity       19       19           
=========================================
  Files           178      178           
  Lines          3630     3630           
  Branches         27       27           
=========================================
  Hits           3432     3432           
  Misses          194      194           
  Partials          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c4f5d...05050ad. Read the comment docs.

Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon peterzhuamazon changed the title Add AD and Alerting to the manifest 2.0.0 Add AD and Alerting to the manifest 2.0.0 and remove CU/Alerting build script Apr 1, 2022
@peterzhuamazon peterzhuamazon requested a review from zelinh April 1, 2022 00:31
Signed-off-by: Peter Zhu <[email protected]>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterzhuamazon peterzhuamazon merged commit 0027384 into opensearch-project:main Apr 1, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-add-manifest branch April 1, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants