Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure alerting is using the build script in its own repo #377

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu [email protected]

Issue #, if available:
#348

Description of changes:
Make sure alerting is using the build script in its own repo

We have 2 Alerting build script, one in build repo one in Alerting repo.
Our code base define that build repo script take priority over the Alerting repo script.
It would be better for Alerting to host their own build script in Alerting repo.

This is a pre-requisite to keep both script consistent before we remove the build script from build repo.

Example existing calls:

2022-03-29 18:42:25 INFO     Executing "bash /var/jenkins/workspace/distribution-build-opensearch/scripts/components/alerting/build.sh -v 1.3.1 -p linux -a arm64 -s false -o builds" in /tmp/tmpz94r2nd7/alerting

CheckList:
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

Codecov Report

Merging #377 (cf1878d) into main (c0698ca) will increase coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #377      +/-   ##
============================================
+ Coverage     79.00%   79.12%   +0.12%     
+ Complexity      268      267       -1     
============================================
  Files           176      176              
  Lines          7286     7286              
  Branches       1016     1016              
============================================
+ Hits           5756     5765       +9     
+ Misses         1004      994      -10     
- Partials        526      527       +1     
Impacted Files Coverage Δ
...ing/destination/client/DestinationEmailClient.java 72.50% <0.00%> (-5.00%) ⬇️
...in/kotlin/org/opensearch/alerting/MonitorRunner.kt 56.22% <0.00%> (-0.34%) ⬇️
...ing/model/destination/DestinationContextFactory.kt 78.57% <0.00%> (+3.57%) ⬆️
...lin/org/opensearch/alerting/alerts/AlertIndices.kt 73.68% <0.00%> (+7.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0698ca...cf1878d. Read the comment docs.

@peterzhuamazon
Copy link
Member Author

The failure of security test is expected as it is not having a running docker.

@peterzhuamazon peterzhuamazon merged commit f5bc959 into opensearch-project:main Apr 1, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-qualifier-4 branch April 1, 2022 02:19
Angie-Zhang pushed a commit to Angie-Zhang/alerting that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants