Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPM M1] Add distribution supported components list so only specific scripts can take -d parameter #1652

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu [email protected]

Description

Add distribution supported components list so only specific scripts can take -d parameter

Issues Resolved

#1651

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #1652 (bb5cc88) into main (803c15f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1652   +/-   ##
=========================================
  Coverage     94.68%   94.69%           
  Complexity       14       14           
=========================================
  Files           163      163           
  Lines          3446     3447    +1     
  Branches         21       21           
=========================================
+ Hits           3263     3264    +1     
  Misses          180      180           
  Partials          3        3           
Impacted Files Coverage Δ
src/build_workflow/builder_from_source.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803c15f...bb5cc88. Read the comment docs.

@peterzhuamazon
Copy link
Member Author

It fixes issues coming from #1629.

@dblock
Copy link
Member

dblock commented Feb 18, 2022

This is a hack and I dislike it very much. I propose we go through the pain of adding support to -d to all these build.sh scripts instead. That should motivate us to get rid of custom steps in scripts so we can have default ones everywhere.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the hack but not checking by name.

src/build_workflow/builder_from_source.py Show resolved Hide resolved
@dblock dblock requested a review from a team February 18, 2022 23:16
@peterzhuamazon peterzhuamazon merged commit 947bc5d into opensearch-project:main Feb 19, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-build-distribution-2 branch February 19, 2022 00:34
@peterzhuamazon peterzhuamazon changed the title Add distribution supported components list so only specific scripts can take -d parameter [RPM M1] Add distribution supported components list so only specific scripts can take -d parameter Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Only send -d to core components, instead of everything.
4 participants