[RPM M1] (Re-open) Update build workflow to build based on distribution (OpenSearch)

[peterzhuamazon]

Signed-off-by: Peter Zhu [email protected]

Description

Update build workflow to build based on distribution (OpenSearch).
You can now use --distribution to build tar/zip/rpm for OpenSearch-min.
Not completely bound to platform anymore.

This would also setup the stage for bundled RPM creation in assemble_workflow (#2073)

Issues Resolved

Part of #1543

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #1629 (eb89ed8) into main (bddbc06) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1629      +/-   ##
============================================
+ Coverage     94.67%   94.68%   +0.01%     
- Complexity       13       14       +1     
============================================
  Files           163      163              
  Lines          3437     3446       +9     
  Branches         21       21              
============================================
+ Hits           3254     3263       +9     
  Misses          180      180              
  Partials          3        3              

Impacted Files	Coverage Δ
src/build_workflow/builder_from_source.py	100.00% <ø> (ø)
src/run_build.py	91.11% <ø> (ø)
src/build_workflow/build_args.py	100.00% <100.00%> (ø)
src/build_workflow/build_recorder.py	100.00% <100.00%> (ø)
src/build_workflow/build_target.py	100.00% <100.00%> (ø)
src/manifests/build_manifest.py	100.00% <100.00%> (ø)
src/jenkins/BuildManifest.groovy	91.66% <0.00%> (+0.23%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bddbc06...eb89ed8. Read the comment docs.

[peterzhuamazon]

Will add more tests tomorrow after all the changes in #1619.

[dblock]

This looks good! Just needs tests.

[dblock]

Good work.

[gaiksaya]

LGTM

[peterzhuamazon]

Thanks @dblock @gaiksaya tho I dont think I have added all the test cases yet :)
I will confirm and add all of those before merging this.

Thanks.

[peterzhuamazon]

The dashboard part still needs some changes to reflect this addition, will issue new PRs on this.
Thanks.

[peterzhuamazon]

@dblock just so you know OSD code does not build rpm correctly: opensearch-project/OpenSearch-Dashboards#1259