Permanent fix for OpenSearch and temp fix for Dashboards startup configurations #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations Signed-off-by: Peter Zhu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1579 +/- ##
============================================
- Coverage 94.46% 94.30% -0.16%
Complexity 12 12
============================================
Files 153 153
Lines 3233 3233
Branches 23 23
============================================
- Hits 3054 3049 -5
- Misses 172 177 +5
Partials 7 7
Continue to review full report at Codecov.
|
peternied
reviewed
Feb 1, 2022
docker/release/config/opensearch-dashboards/opensearch-dashboards-docker-entrypoint.sh
Outdated
Show resolved
Hide resolved
dblock
approved these changes
Feb 1, 2022
docker/release/config/opensearch-dashboards/opensearch-dashboards-docker-entrypoint.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Zhu <[email protected]>
peternied
approved these changes
Feb 1, 2022
peterzhuamazon
added a commit
to peterzhuamazon/opensearch-build
that referenced
this pull request
Feb 16, 2022
…igurations (opensearch-project#1579) * Perma fix for OpenSearch and temp fix for Dashboards startup configurations Signed-off-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu [email protected]
Description
Permanent fix for OpenSearch and temp fix for Dashboards startup configurations.
This PR utilize internal parsing of env var to permanently allow security plugin to be disabled, without the need of tweaking the config file on the fly for OpenSearch.
As for Dashboards, we still need to tweak the configuration file if we want to disable security plugin, so a new tweak is added to temporarily resolve the race condition introduced in #1130 #1458.
As for permanent fix for Dashboards I have opened an issue with Security Dashboards Plugin repo:
opensearch-project/security-dashboards-plugin#896
Thanks.
Issues Resolved
#1529
#1567
opensearch-project/helm-charts#198
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.