Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #1130 where sed and tee is trying to access files at the same time #1458

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jan 12, 2022

Signed-off-by: Peter Zhu [email protected]

Description

Resolve #1130 where sed and tee is trying to access files at the same time.
If we use sed to access file while tee, it would sometimes cause a conflict and result in tee creating empty file due to file is then being held by sed.
Therefore, we cat the file, pipe to sed, then tee, would resolve issue.

Also, fixed an error where sed is not correctly setup for the pattern.

Issues Resolved

#1454

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon self-assigned this Jan 12, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner January 12, 2022 20:25
@peterzhuamazon peterzhuamazon linked an issue Jan 12, 2022 that may be closed by this pull request
@peterzhuamazon peterzhuamazon added the bug Something isn't working label Jan 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #1458 (b33273f) into main (780c28d) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1458      +/-   ##
============================================
- Coverage     94.67%   94.45%   -0.22%     
- Complexity        0       12      +12     
============================================
  Files           120      141      +21     
  Lines          3003     3084      +81     
  Branches          0        8       +8     
============================================
+ Hits           2843     2913      +70     
- Misses          160      164       +4     
- Partials          0        7       +7     
Impacted Files Coverage Δ
src/jenkins/InputManifest.groovy 66.66% <0.00%> (ø)
tests/jenkins/jobs/DetectDockerImage_Jenkinsfile 100.00% <0.00%> (ø)
...sts/jenkins/jobs/ArchiveAssembleUpload_Jenkinsfile 100.00% <0.00%> (ø)
tests/jenkins/jobs/BuildAssembleUpload_Jenkinsfile 100.00% <0.00%> (ø)
.../jenkins/jobs/PromoteArtifacts_actions_Jenkinsfile 100.00% <0.00%> (ø)
src/jenkins/BuildManifest.groovy 100.00% <0.00%> (ø)
tests/jenkins/jobs/GetManifestSHA_Jenkinsfile 100.00% <0.00%> (ø)
tests/jenkins/jobs/PublishNotification_Jenkinsfile 100.00% <0.00%> (ø)
tests/jenkins/jobs/AssembleUpload_Jenkinsfile 100.00% <0.00%> (ø)
tests/jenkins/jobs/Messages_Jenkinsfile 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 780c28d...b33273f. Read the comment docs.

@peterzhuamazon peterzhuamazon merged commit eb7c932 into opensearch-project:main Jan 12, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-docker-1454 branch January 12, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docker v1.2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Entrypoint for Docker image erases config file
5 participants