Add method to get component names from test manifest #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
peterzhuamazon,
prudhvigodithi and
rishabh6788
as code owners
gaiksaya
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
============================================
- Coverage 87.43% 86.04% -1.40%
Complexity 29 29
============================================
Files 81 81
Lines 207 215 +8
Branches 11 12 +1
============================================
+ Hits 181 185 +4
- Misses 19 22 +3
- Partials 7 8 +1 ☔ View full report in Codecov by Sentry. |
|
|
||
| TestManifest(Map data) { | ||
| this.name = data.name | ||
| this.ci = data.ci ? new TestManifest.Ci(data.ci) : null | ||
| this.components = data.components ? new TestManifest.Components(data.components) : null |
There was a problem hiding this comment.
A bit confusion.
Isnt data.components is already the components from TestManifest?
There was a problem hiding this comment.
No it was only present in buildManifest class not the Test Manifest class.
peterzhuamazon
approved these changes
Jan 16, 2024
rishabh6788
approved these changes
Jan 17, 2024
Signed-off-by: Sayali Gaikawad <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit b195cb2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add getComponentNames method from test Manifest
Issues Resolved
opensearch-project/opensearch-build#3461
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.