[Bug]: OpenSearch integration test deploys stages for components absent from test manifest

[gaiksaya]

Describe the bug

Regarding https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/integ-test.jenkinsfile

The jenkins job compares component list from build manifest against the components from the test manifest.
It deploys the jenkins parallel stage, copies everything required and then skips very late in the process that the component is not present in the test manifest.
Also on looking at the https://build.ci.opensearch.org/blue/organizations/jenkins/integ-test/detail/integ-test/4728/pipeline it is very misleading

To reproduce

Just take a look at https://build.ci.opensearch.org/blue/organizations/jenkins/integ-test/detail/integ-test/4728/pipeline

Expected behavior

The comparison should be vice versa; compare components from test manifest against the components in dist or build manifest and deploy parallel stages only for the ones present in the distribution

Screenshots

If applicable, add screenshots to help explain your problem.

Host / Environment

No response

Additional context

No response

Relevant log output

No response

[peterzhuamazon]

Hi,

The description is not fully correct.

The check happens before the s3 download even happens:

https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/integ-test.jenkinsfile#L121-L126

It should stop once there is a mismatch between the build and test manifest which is by design.

Thanks.

[gaiksaya]

The comparison should be opposite. So that only the components in the test manifest shows the stages in jenkins pipeline. By download I mean copy https://build.ci.opensearch.org/blue/organizations/jenkins/integ-test/detail/integ-test/4728/pipeline/112 which is unnecessary. Anyway the python code takes care of the whether the components is present or not so just running for components from test manifest should be sufficient, We do not need to compare at all.

[peterzhuamazon]

Hi,

Talked to @gaiksaya and we are clear now on the right implementation:

1. If user enter specific component name, then compare this name to the test manifest.
2. If use does not enter any specific component name, then just grab all the component names from the test manifest.
3. The getNames func needs to be added in the testManifest obj in lib.

Thanks.

[rishabh6788]

assigning to @gaiksaya to take a look at this.