Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the name of the newly built docker image in dockerPatch library #346

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Divyaasm
Copy link
Collaborator

Description

Resolve the date issue in the name of the docker image and remove the re-release argument that is passed through the jenkins job.

Issues Resolved

Adresses opensearch-project/opensearch-build#4176

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #346 (6a1b3d9) into main (cfaa0f3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #346   +/-   ##
=========================================
  Coverage     87.43%   87.43%           
  Complexity       29       29           
=========================================
  Files            81       81           
  Lines           207      207           
  Branches         11       11           
=========================================
  Hits            181      181           
  Misses           19       19           
  Partials          7        7           
Files Coverage Δ
tests/jenkins/jobs/PatchDockerImage_Jenkinsfile 100.00% <ø> (ø)

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a bumped version number.
Otherwise, looks great!

Thanks.

@Divyaasm
Copy link
Collaborator Author

Please add a bumped version number. Otherwise, looks great!

Thanks.

Going ahead only with the PR changes. As we plan to bump version at a time after multiple changes.

@gaiksaya gaiksaya merged commit 050b31a into opensearch-project:main Oct 31, 2023
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 31, 2023
#346)

Signed-off-by: Divya Madala <[email protected]>
(cherry picked from commit 050b31a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants