Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish snapshots to maven via GHA (#754) #755

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

Zhangxunmt
Copy link
Collaborator

Description

backport the github action maven-publish to main branch to make it runnable.

Issues Resolved

[#734]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Zhangxunmt Zhangxunmt requested a review from a team February 27, 2023 20:02
@MaxKsyunz
Copy link
Contributor

@gaiksaya could you please have a look at this PR as well?

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ylwu-amzn ylwu-amzn merged commit 0f72740 into opensearch-project:main Feb 28, 2023
@Yury-Fridlyand
Copy link
Contributor

@ylwu-amzn @gaiksaya,
I detected a typo in the GHA workflow, so it is not triggered automatically.
Could you please, run the job manually?

@gaiksaya
Copy link
Member

Done! Can someone fix the typo?

@Yury-Fridlyand
Copy link
Contributor

Will do soon. I see it in multiple repos...

@Yury-Fridlyand
Copy link
Contributor

No artifacts were published on the repo recently. Last update was a week ago.
I suspect credentials were not set or configured correctly.

@gaiksaya
Copy link
Member

The right path is here @Yury-Fridlyand https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-ml-plugin/3.0.0.0-SNAPSHOT/ (updated today)
As per the conversation @Zhangxunmt was going to add the task to publish jars later on.

@Yury-Fridlyand
Copy link
Contributor

Oh, I see. SQL plugin depends on ml-common and require jars.

@gaiksaya
Copy link
Member

@Zhangxunmt @ylwu-amzn ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants