Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish snapshots to maven via GHA #754

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Publish snapshots to maven via GHA #754

merged 1 commit into from
Feb 27, 2023

Conversation

Zhangxunmt
Copy link
Collaborator

@Zhangxunmt Zhangxunmt commented Feb 24, 2023 •
edited
Loading

Description

Publish snapshots to maven via GHA

Issues Resolved

[https://github.com//issues/734 ]#734

Tests

find plugin/snapshots | sort
plugin/snapshots
plugin/snapshots/org
plugin/snapshots/org/opensearch
plugin/snapshots/org/opensearch/plugin
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/maven-metadata.xml
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/maven-metadata.xml.md5
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/maven-metadata.xml.sha1
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/maven-metadata.xml.sha256
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/maven-metadata.xml.sha512
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.pom
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.pom.md5
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.pom.sha1
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.pom.sha256
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.pom.sha512
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.zip
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.zip.md5
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.zip.sha1
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.zip.sha256
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.zip.sha512
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml.md5
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml.sha1
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml.sha256
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml.sha512

@Zhangxunmt Zhangxunmt requested a review from a team February 24, 2023 23:07
@Zhangxunmt
Copy link
Collaborator Author

Pending @gaiksaya to create the IAM role that is required to fetch the credentials and add it to the GitHub Secrets.

@Zhangxunmt Zhangxunmt requested a review from gaiksaya February 24, 2023 23:09
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023 •
edited
Loading

Codecov Report

Merging #754 (a270b04) into 2.x (973536c) will decrease coverage by 0.07%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x     #754      +/-   ##
============================================
- Coverage     84.39%   84.33%   -0.07%     
+ Complexity     1591     1589       -2     
============================================
  Files           135      135              
  Lines          5935     5935              
  Branches        560      560              
============================================
- Hits           5009     5005       -4     
- Misses          690      693       +3     
- Partials        236      237       +1
Flag Coverage Δ
ml-commons 84.33% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../cluster/MLCommonsClusterManagerEventListener.java 67.64% <0.00%> (-11.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

MaxKsyunz
MaxKsyunz approved these changes Feb 25, 2023
View reviewed changes
Copy link
Contributor

@MaxKsyunz MaxKsyunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to having this merged.

SQL plugin CI needs the latest snapshot of opensearch-ml-client to build.

gaiksaya
gaiksaya approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@gaiksaya gaiksaya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secrets have been added to the repository

@gaiksaya
Copy link
Member

Hi @Zhangxunmt Would suggest to raise this PR against main first. GHA needs to detect the triggers which is against. It can then be backported to other branches

ylwu-amzn
ylwu-amzn reviewed Feb 27, 2023
View reviewed changes
.github/workflows/maven-publish.yml
export SONATYPE_PASSWORD=$(aws secretsmanager get-secret-value --secret-id maven-snapshots-password --query SecretString --output text)
echo "::add-mask::$SONATYPE_USERNAME"
echo "::add-mask::$SONATYPE_PASSWORD"
./gradlew publishPluginZipPublicationToSnapshotsRepository
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add publish ml-commons client jar to this file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. If needed, will do in a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ylwu-amzn @Zhangxunmt do you mind if @Yury-Fridlyand or myself publish this PR?

SQL plugin needs the snapshot with build fixes before we can merge the PR with our build fixes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, please go ahead! @MaxKsyunz

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaxKsyunz , feel free to cut a new PR

@Zhangxunmt Zhangxunmt merged commit 15a6c0c into opensearch-project:2.x Feb 27, 2023
Zhangxunmt added a commit to Zhangxunmt/ml-commons that referenced this pull request Feb 27, 2023
@Zhangxunmt
Publish snapshots to maven via GHA (opensearch-project#754)
4c85755 
Signed-off-by: Xun Zhang <[email protected]>
ylwu-amzn pushed a commit that referenced this pull request Feb 28, 2023
@Zhangxunmt
Publish snapshots to maven via GHA (#754) (#755)
0f72740 
Signed-off-by: Xun Zhang <[email protected]>
@gaiksaya gaiksaya mentioned this pull request Feb 28, 2023
Merged
5 tasks
This was referenced Feb 28, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxKsyunz MaxKsyunz MaxKsyunz approved these changes

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@gaiksaya gaiksaya gaiksaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zhangxunmt @codecov-commenter @gaiksaya @ylwu-amzn @MaxKsyunz