-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/multi_tenancy] Implement client.bulk in SDK Client #3192
Merged
dhrubo-os
merged 15 commits into
opensearch-project:feature/multi_tenancy
from
dbwiddis:bulk-action
Nov 21, 2024
Merged
[Feature/multi_tenancy] Implement client.bulk in SDK Client #3192
dhrubo-os
merged 15 commits into
opensearch-project:feature/multi_tenancy
from
dbwiddis:bulk-action
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
sam-herman
as code owners
October 30, 2024 07:56
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 07:56 — with
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 07:56 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 07:56 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 07:56 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 07:56 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 07:56 — with
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 20:07 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 20:07 — with
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 20:07 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 20:07 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 20:07 — with
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 20:07 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 22:10 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 22:10 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 22:10 — with
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
October 30, 2024 22:10 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 14, 2024 21:35 — with
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 14, 2024 21:35 — with
GitHub Actions
Error
dhrubo-os
approved these changes
Nov 19, 2024
common/src/main/java/org/opensearch/sdk/client/LocalClusterIndicesClient.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/opensearch/ml/sdkclient/DDBOpenSearchClient.java
Show resolved
Hide resolved
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 20, 2024 03:34 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 20, 2024 03:34 — with
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 20, 2024 03:34 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 20, 2024 03:34 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 20, 2024 03:34 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 20, 2024 03:34 — with
GitHub Actions
Failure
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
November 20, 2024 18:07 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
November 20, 2024 18:07 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
November 20, 2024 18:07 — with
GitHub Actions
Inactive
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 20, 2024 18:07 — with
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 20, 2024 18:07 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 20, 2024 18:07 — with
GitHub Actions
Error
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
November 20, 2024 18:42 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
November 20, 2024 18:42 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
November 20, 2024 18:42 — with
GitHub Actions
Inactive
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 20, 2024 18:42 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 20, 2024 18:42 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
November 20, 2024 18:42 — with
GitHub Actions
Failure
arjunkumargiri
approved these changes
Nov 20, 2024
dhrubo-os
approved these changes
Nov 21, 2024
dhrubo-os
merged commit Nov 21, 2024
3bbc700
into
opensearch-project:feature/multi_tenancy
7 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an SDKClient equivalent to
client.bulk()
.Summary of changes (helpful for reviewers):
DataObjectRequest
parent class. I originally started with a tagging interface just to help method signatures, but realized that four classes duplicated the same code for the index, id, and tenantId fields, so refactored those (and the associated builder code) into the superclass. Existing unit tests cover this change. caeea21DataObjectResponse
parent class similar to above, refactoring the id and parser fields from the subclass. Existing unit tests cover this change. 445936b (part 1)BulkDataObjectRequest
andBulkDataObjectResponse
classes and unit tests. Added afailed
field to the response superclass to track failures/errors. 445936b (part 2).bulk()
method, and unit tests 22dccf4In addition there are several whitespace / import reordering changes due to spotless not having been run on the common module.
Will be handled integ tests in #2818
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.