[Feature/multi_tenancy] Tenant-aware integration tests for Connector, Model, Agent, Model Groups #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
sam-herman
as code owners
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]> # Conflicts: # plugin/src/main/java/org/opensearch/ml/settings/MLFeatureEnabledSetting.java
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
reviewed
Nov 26, 2024
| // "error": { | ||
| // "root_cause": [ | ||
| // { | ||
| // "type": "status_exception", |
There was a problem hiding this comment.
Why it's showing 2 times?
There was a problem hiding this comment.
Do you know from where are we getting this status_exception? May be we can change that to OpenSearchStatusException too? I can make the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests the entire Create-Get-Update-Search-Delete cycle with multi-tenancy (both enabled and not).
Validates expected results when tenant aware and when not (current status quo).
Looking for review on the approach before replicating to models and agents and other tenant-aware updates, although I won't wait before starting that work. If you want a simpler review, get started now. :)
To execute just these tests:
or
Because the classes end in
IT, the "false" version executes with normal integ tests as well, a separate test needs to be done for thetruecase.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.