Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] add code coverage report for commons and memory modules #1574

Merged
merged 11 commits into from
Nov 2, 2023

Conversation

TrungBui59
Copy link
Contributor

@TrungBui59 TrungBui59 commented Oct 31, 2023

Description

Change the build.gradle file for common and memory modules so that it will send the reports to codecov. I have tested it using my personal codecov account

Issues Resolved

#1542

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhrubo-os
Copy link
Collaborator

Could you please resolve the conflict?

@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 2, 2023 20:49 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 2, 2023 20:49 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 2, 2023 20:49 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 2, 2023 20:51 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 2, 2023 20:51 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 2, 2023 20:51 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 2, 2023 22:11 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 2, 2023 22:11 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 2, 2023 22:11 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 2, 2023 22:11 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os merged commit 510f50b into opensearch-project:main Nov 2, 2023
10 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 2, 2023
)

* Test CI for codecov

Signed-off-by: TrungBui59 <[email protected]>

* Change the gradle files for codecov

Signed-off-by: TrungBui59 <[email protected]>

* Fixing gradle file to support for codecov

Signed-off-by: TrungBui59 <[email protected]>

* change the todo

Signed-off-by: TrungBui59 <[email protected]>

---------

Signed-off-by: TrungBui59 <[email protected]>
(cherry picked from commit 510f50b)
ylwu-amzn pushed a commit that referenced this pull request Nov 2, 2023
) (#1585)

* Test CI for codecov

Signed-off-by: TrungBui59 <[email protected]>

* Change the gradle files for codecov

Signed-off-by: TrungBui59 <[email protected]>

* Fixing gradle file to support for codecov

Signed-off-by: TrungBui59 <[email protected]>

* change the todo

Signed-off-by: TrungBui59 <[email protected]>

---------

Signed-off-by: TrungBui59 <[email protected]>
(cherry picked from commit 510f50b)

Co-authored-by: Trung Bùi <[email protected]>
TrungBui59 added a commit to TrungBui59/ml-commons that referenced this pull request Nov 6, 2023
…ensearch-project#1574)

* Test CI for codecov

Signed-off-by: TrungBui59 <[email protected]>

* Change the gradle files for codecov

Signed-off-by: TrungBui59 <[email protected]>

* Fixing gradle file to support for codecov

Signed-off-by: TrungBui59 <[email protected]>

* change the todo

Signed-off-by: TrungBui59 <[email protected]>

---------

Signed-off-by: TrungBui59 <[email protected]>
TrungBui59 added a commit to TrungBui59/ml-commons that referenced this pull request Nov 6, 2023
…ensearch-project#1574)

* Test CI for codecov

Signed-off-by: TrungBui59 <[email protected]>

* Change the gradle files for codecov

Signed-off-by: TrungBui59 <[email protected]>

* Fixing gradle file to support for codecov

Signed-off-by: TrungBui59 <[email protected]>

* change the todo

Signed-off-by: TrungBui59 <[email protected]>

---------

Signed-off-by: TrungBui59 <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
…ensearch-project#1574)

* Test CI for codecov

Signed-off-by: TrungBui59 <[email protected]>

* Change the gradle files for codecov

Signed-off-by: TrungBui59 <[email protected]>

* Fixing gradle file to support for codecov

Signed-off-by: TrungBui59 <[email protected]>

* change the todo

Signed-off-by: TrungBui59 <[email protected]>

---------

Signed-off-by: TrungBui59 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants