Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] add code coverage report for commons and memory modules #1542

Closed
dhrubo-os opened this issue Oct 24, 2023 · 5 comments
Closed

[FEATURE] add code coverage report for commons and memory modules #1542

dhrubo-os opened this issue Oct 24, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dhrubo-os
Copy link
Collaborator

Is your feature request related to a problem?

Currently in ml-commons we see code coverage for 4 modules but not for other modules: opensearch-ml-commons and opensearch-ml-memory

We need to add similar like this in the corresponding build.gradle file for the modules.

@dhrubo-os dhrubo-os added enhancement New feature or request untriaged good first issue Good for newcomers and removed untriaged labels Oct 24, 2023
@ylwu-amzn ylwu-amzn changed the title [FEATURE] [FEATURE] add code coverage report for commons and memory modules Oct 24, 2023
@austintlee
Copy link
Collaborator

jacocoTestReport {
reports {
html.required = true
html.outputLocation = layout.buildDirectory.dir('jacocoHtml')
}
dependsOn test
}

Isn't this it?

@dhrubo-os
Copy link
Collaborator Author

I don't see memory module here

@TrungBui59
Copy link
Contributor

@dhrubo-os can you assign this to me please?

@dhrubo-os
Copy link
Collaborator Author

@TrungBui59 assigned to you.

@dhrubo-os
Copy link
Collaborator Author

Thanks @TrungBui59 for solving this issue. We can see all the modules of the ml-commons now here.

@github-project-automation github-project-automation bot moved this from In Progress to Done in ml-commons projects Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Development

No branches or pull requests

3 participants