-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 0.95 as default ratio for lucene radial search traversal similarity #1619
Use 0.95 as default ratio for lucene radial search traversal similarity #1619
Conversation
Signed-off-by: Junqiu Lei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, but everything else looks good to me!
Signed-off-by: Junqiu Lei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Junqiu Lei <[email protected]>
overall code looks good to me. Waiting for CIs to complete. |
Signed-off-by: Junqiu Lei <[email protected]>
Will do manually backport to 2.x with #1617 |
…search-project#1652) * Use 0.95 as default ratio for lucene radial search traversal similarity (opensearch-project#1619) Signed-off-by: Junqiu Lei <[email protected]>
… (#1658) * Use 0.95 as default ratio for lucene radial search traversal similarity (#1619) Signed-off-by: Junqiu Lei <[email protected]>
Description
This PR set up Lucene engine traversalSimilarity value to 0.95 * resultSimilarity(min_score) based on benchmark result #814 (comment)
Issues Resolved
Part of #814
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.