-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ignore unmapped minimum version #1239
Fix ignore unmapped minimum version #1239
Conversation
Signed-off-by: Ryan Bogan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #1239 +/- ##
============================================
+ Coverage 85.06% 85.12% +0.06%
Complexity 1187 1187
============================================
Files 155 155
Lines 4881 4881
Branches 450 450
============================================
+ Hits 4152 4155 +3
+ Misses 530 527 -3
Partials 199 199
|
Shouldn't we push the change to main as well? |
Raising a PR for that shortly |
Signed-off-by: Ryan Bogan <[email protected]> (cherry picked from commit 9d2086c)
+1, we may remove that later from main, but for now it's better to have it in main. FYI, rolling upgrades are supported for all minor versions of current major, plus the last one for the previous major. E.g. if we do 2.12 and then 3.0, then we don't need support for 2.11 in 3.x codeline. |
@martin-gaievski @heemin32 looks like main already has the version as 2.11 |
Description
Fixes incorrect minimum required version to use ignore_unmapped functionality
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.