Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Backport 2.x] Add ignore_unmapped support in KNNQueryBuilder… #1238

Closed
wants to merge 1 commit into from

Conversation

heemin32
Copy link
Collaborator

Description

This reverts commit 39836c6.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1238 (ea41fce) into 2.11 (f807aa2) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               2.11    #1238      +/-   ##
============================================
+ Coverage     85.00%   85.17%   +0.17%     
+ Complexity     1184     1179       -5     
============================================
  Files           155      155              
  Lines          4881     4851      -30     
  Branches        450      442       -8     
============================================
- Hits           4149     4132      -17     
+ Misses          533      522      -11     
+ Partials        199      197       -2     
Files Coverage Δ
.../main/java/org/opensearch/knn/index/IndexUtil.java 55.73% <ø> (-6.24%) ⬇️
...rg/opensearch/knn/index/query/KNNQueryBuilder.java 85.18% <100.00%> (+2.21%) ⬆️

... and 4 files with indirect coverage changes

@heemin32
Copy link
Collaborator Author

Closing in favor of #1239

@heemin32 heemin32 closed this Oct 11, 2023
@heemin32 heemin32 deleted the revert branch July 18, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants