-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated MAINTAINERS.md format. #296
Merged
saratvemulapalli
merged 1 commit into
opensearch-project:main
from
dblock:updated-maintainers
Jan 9, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,13 @@ | ||
| ## Maintainers | ||
| | Maintainer | GitHub ID | Affiliation | | ||
| | --------------- | --------- | ----------- | | ||
| | Ashish Agrawal | [lezzago](https://github.com/lezzago) | Amazon | | ||
| | Bowen Lan | [bowenlan-amzn](https://github.com/bowenlan-amzn) | Amazon | | ||
| | Drew Baugher | [dbbaughe](https://github.com/dbbaughe) | Amazon | | ||
| | Mohammad Qureshi | [qreshi](https://github.com/qreshi) | Amazon | | ||
| | Sriram Kosuri | [skkosuri-amzn](https://github.com/skkosuri-amzn) | Amazon | | ||
| ## Overview | ||
|
|
||
| [This document](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md) explains what maintainers do in this repo, and how they should be doing it. If you're interested in contributing, see [CONTRIBUTING](CONTRIBUTING.md). | ||
| This document contains a list of maintainers in this repo. See [opensearch-project/.github/RESPONSIBILITIES.md](https://github.com/opensearch-project/.github/blob/main/RESPONSIBILITIES.md#maintainer-responsibilities) that explains what the role of maintainer means, what maintainers do in this and other repos, and how they should be doing it. If you're interested in contributing, and becoming a maintainer, see [CONTRIBUTING](CONTRIBUTING.md). | ||
|
|
||
| ## Current Maintainers | ||
|
|
||
| | Maintainer | GitHub ID | Affiliation | | ||
| | ---------------- | ------------------------------------------------- | ----------- | | ||
| | Ashish Agrawal | [lezzago](https://github.com/lezzago) | Amazon | | ||
| | Bowen Lan | [bowenlan-amzn](https://github.com/bowenlan-amzn) | Amazon | | ||
| | Drew Baugher | [dbbaughe](https://github.com/dbbaughe) | Amazon | | ||
| | Mohammad Qureshi | [qreshi](https://github.com/qreshi) | Amazon | | ||
| | Sriram Kosuri | [skkosuri-amzn](https://github.com/skkosuri-amzn) | Amazon | | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list really doesnt match the maintainers for JS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshpalis do you happen to have the latest list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the current list in the file though. Can we baseline the list, align CODEOWNERS and update separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this list is missing me and @dbwiddis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All I am saying is that it was missing you two. Can we merge this PR which just changes the format and then ya'll can go and fix the list in a subsequent PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, we dont have to block this, @joshpalis do you mind sending out a PR?