Updated MAINTAINERS.md format. #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dblock <[email protected]>
joshpalis
approved these changes
Jan 5, 2023
saratvemulapalli
previously approved these changes
Jan 5, 2023
Comment on lines
+8
to
+13
| | ---------------- | ------------------------------------------------- | ----------- | | ||
| | Ashish Agrawal | [lezzago](https://github.com/lezzago) | Amazon | | ||
| | Bowen Lan | [bowenlan-amzn](https://github.com/bowenlan-amzn) | Amazon | | ||
| | Drew Baugher | [dbbaughe](https://github.com/dbbaughe) | Amazon | | ||
| | Mohammad Qureshi | [qreshi](https://github.com/qreshi) | Amazon | | ||
| | Sriram Kosuri | [skkosuri-amzn](https://github.com/skkosuri-amzn) | Amazon | |
There was a problem hiding this comment.
This list really doesnt match the maintainers for JS.
There was a problem hiding this comment.
@joshpalis do you happen to have the latest list?
There was a problem hiding this comment.
It's the current list in the file though. Can we baseline the list, align CODEOWNERS and update separately?
There was a problem hiding this comment.
I believe this list is missing me and @dbwiddis
There was a problem hiding this comment.
All I am saying is that it was missing you two. Can we merge this PR which just changes the format and then ya'll can go and fix the list in a subsequent PR?
There was a problem hiding this comment.
That makes sense, we dont have to block this, @joshpalis do you mind sending out a PR?
87 tasks
saratvemulapalli
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from opensearch-project/.github#121, updated MAINTAINERS.md to match opensearch-project recommended format.