-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security Workflow #611
Security Workflow #611
Conversation
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
============================================
- Coverage 75.32% 75.24% -0.08%
+ Complexity 2605 2588 -17
============================================
Files 330 330
Lines 15111 15115 +4
Branches 2337 2338 +1
============================================
- Hits 11382 11374 -8
+ Misses 2397 2396 -1
- Partials 1332 1345 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
c5a44f6
to
d867f9b
Compare
Signed-off-by: bowenlan-amzn <[email protected]>
6f8d25c
to
0b5170b
Compare
6c86be5
to
341b48c
Compare
Signed-off-by: bowenlan-amzn <[email protected]>
cdedcf0
to
4c8b15f
Compare
70368e1
to
134df7b
Compare
134df7b
to
d65b85e
Compare
Signed-off-by: bowenlan-amzn <[email protected]>
d65b85e
to
0647d5b
Compare
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * security workflow setup Signed-off-by: bowenlan-amzn <[email protected]> * add more settings Signed-off-by: bowenlan-amzn <[email protected]> * Rewrite SecureRestClientBuilder Signed-off-by: bowenlan-amzn <[email protected]> * For now, use local cluster Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit f2a9fa6)
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * security workflow setup Signed-off-by: bowenlan-amzn <[email protected]> * add more settings Signed-off-by: bowenlan-amzn <[email protected]> * Rewrite SecureRestClientBuilder Signed-off-by: bowenlan-amzn <[email protected]> * For now, use local cluster Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit f2a9fa6) Co-authored-by: bowenlan-amzn <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-611-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f2a9fa6ef05227f3c048b5e59a5852b18c1e98e1
# Push it to GitHub
git push --set-upstream origin backport/backport-611-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4 Then, create a pull request where the |
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * security workflow setup Signed-off-by: bowenlan-amzn <[email protected]> * add more settings Signed-off-by: bowenlan-amzn <[email protected]> * Rewrite SecureRestClientBuilder Signed-off-by: bowenlan-amzn <[email protected]> * For now, use local cluster Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit f2a9fa6)
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * security workflow setup Signed-off-by: bowenlan-amzn <[email protected]> * add more settings Signed-off-by: bowenlan-amzn <[email protected]> * Rewrite SecureRestClientBuilder Signed-off-by: bowenlan-amzn <[email protected]> * For now, use local cluster Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit f2a9fa6) Co-authored-by: bowenlan-amzn <[email protected]> (cherry picked from commit ed54fee)
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * security workflow setup Signed-off-by: bowenlan-amzn <[email protected]> * add more settings Signed-off-by: bowenlan-amzn <[email protected]> * Rewrite SecureRestClientBuilder Signed-off-by: bowenlan-amzn <[email protected]> * For now, use local cluster Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]>
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * security workflow setup Signed-off-by: bowenlan-amzn <[email protected]> * add more settings Signed-off-by: bowenlan-amzn <[email protected]> * Rewrite SecureRestClientBuilder Signed-off-by: bowenlan-amzn <[email protected]> * For now, use local cluster Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]>
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * security workflow setup Signed-off-by: bowenlan-amzn <[email protected]> * add more settings Signed-off-by: bowenlan-amzn <[email protected]> * Rewrite SecureRestClientBuilder Signed-off-by: bowenlan-amzn <[email protected]> * For now, use local cluster Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]>
* Security Workflow (#611) * Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * security workflow setup Signed-off-by: bowenlan-amzn <[email protected]> * add more settings Signed-off-by: bowenlan-amzn <[email protected]> * Rewrite SecureRestClientBuilder Signed-off-by: bowenlan-amzn <[email protected]> * For now, use local cluster Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> * Fix deps missing Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]>
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * security workflow setup Signed-off-by: bowenlan-amzn <[email protected]> * add more settings Signed-off-by: bowenlan-amzn <[email protected]> * Rewrite SecureRestClientBuilder Signed-off-by: bowenlan-amzn <[email protected]> * For now, use local cluster Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit f2a9fa6) Co-authored-by: bowenlan-amzn <[email protected]>
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * security workflow setup Signed-off-by: bowenlan-amzn <[email protected]> * add more settings Signed-off-by: bowenlan-amzn <[email protected]> * Rewrite SecureRestClientBuilder Signed-off-by: bowenlan-amzn <[email protected]> * For now, use local cluster Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit f2a9fa6) Co-authored-by: bowenlan-amzn <[email protected]> Signed-off-by: Ronnak Saxena <[email protected]>
Issue #, if available:
#612
Description of changes:
During 2.4 release, we only caught this bug #608 until Infra runs security test. A code change was made in security enabled code path, but we don't have security test running along with each PR.
This PR dives deep into the way of running security test using github workflow and resolve the long standing problem of SSL connection error when directly run security test using integTest task.
./gradlew integTest -Dsecurity=true
..github/workflows/security-test-workflow.yml
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.