Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a super admin client builder w/ hosts params #322

Merged

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Nov 18, 2022

Signed-off-by: bowenlan-amzn [email protected]

Description

Duplicate the super admin client constructor with hosts params. Currently we hardcode the host to be localhost:9200 in super admin client.

Issues Resolved

opensearch-project/index-management#612

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

Codecov Report

Merging #322 (65281f8) into main (5fd25b0) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #322      +/-   ##
============================================
- Coverage     73.42%   73.29%   -0.13%     
+ Complexity      698      696       -2     
============================================
  Files           110      110              
  Lines          4587     4595       +8     
  Branches        606      606              
============================================
  Hits           3368     3368              
- Misses          968      976       +8     
  Partials        251      251              
Impacted Files Coverage Δ
...ensearch/commons/rest/SecureRestClientBuilder.java 49.13% <0.00%> (-3.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review November 18, 2022 21:43
@bowenlan-amzn bowenlan-amzn requested a review from a team November 18, 2022 21:43
@bowenlan-amzn bowenlan-amzn merged commit 050c95d into opensearch-project:main Nov 19, 2022
@bowenlan-amzn bowenlan-amzn deleted the superadminclient branch November 19, 2022 00:39
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 19, 2022
Signed-off-by: bowenlan-amzn <[email protected]>

Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 050c95d)
bowenlan-amzn added a commit that referenced this pull request Nov 19, 2022
Signed-off-by: bowenlan-amzn <[email protected]>

Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 050c95d)

Co-authored-by: bowenlan-amzn <[email protected]>
wuychn pushed a commit to ochprince/common-utils that referenced this pull request Mar 16, 2023
) (opensearch-project#323)

Signed-off-by: bowenlan-amzn <[email protected]>

Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 050c95d)

Co-authored-by: bowenlan-amzn <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
) (opensearch-project#323)

Signed-off-by: bowenlan-amzn <[email protected]>

Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 050c95d)

Co-authored-by: bowenlan-amzn <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants