-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-inclusive nonmenclature update #337
Non-inclusive nonmenclature update #337
Conversation
Signed-off-by: bowenlan-amzn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #337 +/- ##
============================================
- Coverage 75.54% 75.35% -0.20%
+ Complexity 2133 2131 -2
============================================
Files 260 260
Lines 12341 12341
Branches 1942 1942
============================================
- Hits 9323 9299 -24
- Misses 1963 1990 +27
+ Partials 1055 1052 -3
Continue to review full report at Codecov.
|
I see that a lot of the rest apis are being deprecated which used Master, and it looks like we aren't changing any of those in this PR. opensearch-project/documentation-website#450 |
The master usage left in our code base is in the variable, method names from core code base. I think we will do a replacement at 3.0 directly. Other than that, it's the master_timeout param, will do as #285 (comment) |
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn [email protected]
Issue #, if available:
#285
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.