-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the "Master" nomenclature #285
Comments
For 2.0, at a minimum please ensure that the plugin is not calling any deprecated APIs in core or another plugin, and confirm below, then remove the 2.0.0 label. If you have time, do the complete deprecation as described in this issue. |
@opensearch-project/index-management Can you please verify @dblock's question so we can remove the 2.0 label? Thanks |
@tlfeng helps pointing out the Line 80 in 2d3fd97
And the related issue: opensearch-project/OpenSearch#2928 |
Java APIs completed and released on 2.2 except for AcknowledgedResponse. |
Is your feature request related to a problem? Please describe.
OpenSearch repository is going to replace the terminology "master"with "cluster manager".
issue: opensearch-project/OpenSearch#472, with the plan for its terminology replacement.
Although the existing usages with "master" will be supported in OpenSearch version 2.x until further notice to keep the backwards compatibility, please prepare for the nomenclature change in advance, and replace all the usages with "master" terminology in the code base.
Describe the solution you'd like
Replace the terminology "master" with "cluster manager".
When being compatible with OpenSearch 2.0:
deprecate parameter "master_timeout" and add new parameter "cluster_manager_timeout" in RestExplainAction (updated after the below comment)
When being compatible with OpenSearch 3.0:
(most of the new APIs are available in version 2.2, except
AcknowledgedResponse
)Describe alternatives you've considered
None.
Additional context
Related issues:
Note about the API request parameter
master_timeout
:From my understanding, the parameter
master_timeout
is used in "Explain Index" API of the plugin, and it's independent with OpenSearch (core), so you could deal with it alone.I suggest to deprecate the request parameter
master_timeout
, and add a new request parametercluster_manager_timeout
. Then remove the support of parametermaster_timeout
in the future.How OpenSearch deal with the API request parameter
master_timeout
:In OpenSearch, the parameter
master_timeout
is deprecated and will be replaced by parametercluster_manager_timeout
.The code change was tracked in the issue opensearch-project/OpenSearch#2511
The timeline for deprecating the parameter
master_timeout
is special in OpenSearch (core):cluster_manager_timeout
is added, while no warning for usingmaster_timeout
.master_timeout
.master_timeout
will be removed.Technically it is fine to keep using the parameter
master_timeout
when being compatible with OpenSearch 2.0, but deprecation warning will be shown in 3.0 .The text was updated successfully, but these errors were encountered: