Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.1] Snapshot management small fixes #209

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2947db6 from #208

* Add notification

Signed-off-by: bowenlan-amzn <[email protected]>

* Default timestamp in snapshot name

Signed-off-by: bowenlan-amzn <[email protected]>

* Make custom configuration in create repo more prominent

Signed-off-by: bowenlan-amzn <[email protected]>

* Tune the snapshots table to have more space for showing snapshot name

Signed-off-by: bowenlan-amzn <[email protected]>

* Show notification channel name on policy detail page

Signed-off-by: bowenlan-amzn <[email protected]>

* Helptext word change

Signed-off-by: bowenlan-amzn <[email protected]>

* Add snapshot management to left side bar

Signed-off-by: bowenlan-amzn <[email protected]>

* max age unit sync with snapshot frequency type hourly

Signed-off-by: bowenlan-amzn <[email protected]>

* Notification link to detail in policy detail page

Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 2947db6)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team June 28, 2022 19:17
@AWSHurneyt
Copy link
Contributor

Should this be backported to the 2.x branch, and then backported from 2.x to 2.1?

@codecov-commenter
Copy link

Codecov Report

Merging #209 (2947db6) into 2.1 (f08cbe2) will decrease coverage by 0.25%.
The diff coverage is n/a.

❗ Current head 2947db6 differs from pull request most recent head 98d556b. Consider uploading reports for the commit 98d556b to get more accurate results

@@            Coverage Diff             @@
##              2.1     #209      +/-   ##
==========================================
- Coverage   51.84%   51.58%   -0.26%     
==========================================
  Files         182      183       +1     
  Lines        5750     5798      +48     
  Branches      924      934      +10     
==========================================
+ Hits         2981     2991      +10     
- Misses       2548     2586      +38     
  Partials      221      221              
Impacted Files Coverage Δ
...ards-plugin/public/services/NotificationService.ts 70.00% <0.00%> (-30.00%) ⬇️
...hotPolicy/components/CronSchedule/CronSchedule.tsx 11.76% <0.00%> (-0.24%) ⬇️
.../CreateRepositoryFlyout/CreateRepositoryFlyout.tsx 12.69% <0.00%> (-0.21%) ⬇️
...ement-dashboards-plugin/public/pages/Main/Main.tsx 7.54% <0.00%> (-0.15%) ⬇️
...s/containers/SnapshotPolicies/SnapshotPolicies.tsx 7.51% <0.00%> (-0.12%) ⬇️
...ndex-management-dashboards-plugin/public/plugin.ts 0.00% <0.00%> (ø)
...gement-dashboards-plugin/public/utils/constants.ts 100.00% <0.00%> (ø)
...gin/public/pages/CreateSnapshotPolicy/constants.ts 0.00% <0.00%> (ø)
...pages/Snapshots/containers/Snapshots/Snapshots.tsx 4.59% <0.00%> (ø)
...ents/CreateSnapshotFlyout/CreateSnapshotFlyout.tsx 12.98% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08cbe2...98d556b. Read the comment docs.

@bowenlan-amzn
Copy link
Member

Should this be backported to the 2.x branch, and then backported from 2.x to 2.1?

Haven't created 2.x yet, so 2.1

@bowenlan-amzn bowenlan-amzn merged commit b12299f into 2.1 Jun 28, 2022
@github-actions github-actions bot deleted the backport/backport-208-to-2.1 branch June 28, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants