Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot management small fixes #208

Merged
merged 13 commits into from
Jun 28, 2022

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Jun 27, 2022

Signed-off-by: bowenlan-amzn [email protected]

Description

  • Notification integration is added
  • Remove timestamp input from create policy page, because we haven't finalized the design for it before release 2.1
  • Make custom configuration help text in create repo flyout more prominent
  • Tune the snapshot table to have more space for showing snapshot name which could be long
  • Show notification channel name and type instead of id in policy detail page
  • Add snapshot management to left nav bar under opensearch plugins, in the future, these may move to management section.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #208 (b13df42) into main (f08cbe2) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   51.84%   51.59%   -0.25%     
==========================================
  Files         182      183       +1     
  Lines        5750     5795      +45     
  Branches      924      933       +9     
==========================================
+ Hits         2981     2990       +9     
- Misses       2548     2584      +36     
  Partials      221      221              
Impacted Files Coverage Δ
...ards-plugin/public/services/NotificationService.ts 70.00% <0.00%> (-30.00%) ⬇️
...hotPolicy/components/CronSchedule/CronSchedule.tsx 11.76% <0.00%> (-0.24%) ⬇️
.../CreateRepositoryFlyout/CreateRepositoryFlyout.tsx 12.69% <0.00%> (-0.21%) ⬇️
...ement-dashboards-plugin/public/pages/Main/Main.tsx 7.54% <0.00%> (-0.15%) ⬇️
...s/containers/SnapshotPolicies/SnapshotPolicies.tsx 7.51% <0.00%> (-0.12%) ⬇️
...ndex-management-dashboards-plugin/public/plugin.ts 0.00% <0.00%> (ø)
...gement-dashboards-plugin/public/utils/constants.ts 100.00% <0.00%> (ø)
...gin/public/pages/CreateSnapshotPolicy/constants.ts 0.00% <0.00%> (ø)
...pages/Snapshots/containers/Snapshots/Snapshots.tsx 4.59% <0.00%> (ø)
...ents/CreateSnapshotFlyout/CreateSnapshotFlyout.tsx 12.98% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08cbe2...b13df42. Read the comment docs.

Signed-off-by: bowenlan-amzn <[email protected]>
@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review June 28, 2022 01:22
@bowenlan-amzn bowenlan-amzn requested a review from a team June 28, 2022 01:22
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
@bowenlan-amzn bowenlan-amzn merged commit 2947db6 into opensearch-project:main Jun 28, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 28, 2022
* Add notification

Signed-off-by: bowenlan-amzn <[email protected]>

* Default timestamp in snapshot name

Signed-off-by: bowenlan-amzn <[email protected]>

* Make custom configuration in create repo more prominent

Signed-off-by: bowenlan-amzn <[email protected]>

* Tune the snapshots table to have more space for showing snapshot name

Signed-off-by: bowenlan-amzn <[email protected]>

* Show notification channel name on policy detail page

Signed-off-by: bowenlan-amzn <[email protected]>

* Helptext word change

Signed-off-by: bowenlan-amzn <[email protected]>

* Add snapshot management to left side bar

Signed-off-by: bowenlan-amzn <[email protected]>

* max age unit sync with snapshot frequency type hourly

Signed-off-by: bowenlan-amzn <[email protected]>

* Notification link to detail in policy detail page

Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 2947db6)
bowenlan-amzn added a commit that referenced this pull request Jun 28, 2022
* Add notification

Signed-off-by: bowenlan-amzn <[email protected]>

* Default timestamp in snapshot name

Signed-off-by: bowenlan-amzn <[email protected]>

* Make custom configuration in create repo more prominent

Signed-off-by: bowenlan-amzn <[email protected]>

* Tune the snapshots table to have more space for showing snapshot name

Signed-off-by: bowenlan-amzn <[email protected]>

* Show notification channel name on policy detail page

Signed-off-by: bowenlan-amzn <[email protected]>

* Helptext word change

Signed-off-by: bowenlan-amzn <[email protected]>

* Add snapshot management to left side bar

Signed-off-by: bowenlan-amzn <[email protected]>

* max age unit sync with snapshot frequency type hourly

Signed-off-by: bowenlan-amzn <[email protected]>

* Notification link to detail in policy detail page

Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 2947db6)

Co-authored-by: bowenlan-amzn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants