Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete snippets from 2.11 documentation #6492

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Delete snippets from 2.11 documentation #6492

merged 2 commits into from
Feb 26, 2024

Conversation

vagimeli
Copy link
Contributor

Description

the functionality of field and target_field in kv processor supports template snippets which this issue calls out will be released in 2.12.0, and will not be backported to 2.11. remove the description of Supports [template snippets] in the document of 2.11.

Issues Resolved

See (#5651)

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli vagimeli self-assigned this Feb 22, 2024
@vagimeli vagimeli added the backport 2.11 PR: Backport label for 2.11 label Feb 22, 2024
@vagimeli
Copy link
Contributor Author

@gaobinlong I've deleted the template snippets language from the 2.11 documentation. I'll get this reviewed and merged today (2/22). Thank you :)

cc: @hdhalter

Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as long as @gaobinlong approves. Thanks!

Copy link
Contributor

@gaobinlong gaobinlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vagimeli vagimeli merged commit 424c7dd into main Feb 26, 2024
4 checks passed
@vagimeli vagimeli deleted the delete-snippets branch February 26, 2024 16:28
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Melissa Vagi <[email protected]>
(cherry picked from commit 424c7dd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Feb 26, 2024
(cherry picked from commit 424c7dd)

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
oeyh pushed a commit to oeyh/documentation-website that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.11 PR: Backport label for 2.11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants