Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] The parameter field and target_field in KV ingest processor now supports template snippets #5651

Closed
1 of 4 tasks
gaobinlong opened this issue Nov 22, 2023 · 8 comments
Closed
1 of 4 tasks
Assignees
Labels
3 - Done Issue is done/complete v2.12.0
Milestone

Comments

@gaobinlong
Copy link
Contributor

gaobinlong commented Nov 22, 2023

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.

The parameter field and target_field in KV ingest processor will support template snippets in 2.12, we need to add this enhancement to the documentation. I see that currently we don't have documentation for kv processor, so please include this change when we add the documentation.

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
opensearch-project/OpenSearch#10040

@reta
Copy link
Contributor

reta commented Nov 22, 2023

FYI, the target is 2.12.0

@hdhalter
Copy link
Contributor

Thanks, @gaobinlong and @reta ! Who will be writing the documentation for this feature?

In the meantime, I've asked @vagimeli to prioritize on the kv processor, since she is working on the processor documentation currently.

@hdhalter hdhalter added v2.12.0 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. and removed untriaged labels Nov 22, 2023
@hdhalter hdhalter added this to the v2.12 milestone Nov 22, 2023
@reta
Copy link
Contributor

reta commented Nov 22, 2023

Thanks, @gaobinlong and @reta ! Who will be writing the documentation for this feature?

I believe the author of the change (@gaobinlong) should be writing it

@vagimeli
Copy link
Contributor

vagimeli commented Dec 4, 2023

@reta @gaobinlong See PR ##5781. Content in progress. I'll tag you both when it's ready for your review.

@gaobinlong
Copy link
Contributor Author

Close this issue as the related PR has been merged yet.

@hdhalter
Copy link
Contributor

@gaobinlong - Does the merged PR contain the information being delivered in 2.12? I believe 5781 was written based on 2.11, but just want to confirm. Thanks!

@vagimeli
Copy link
Contributor

vagimeli commented Jan 30, 2024

This issue has been addressed in the documentation for 2.11 and 2.12. See PR #5781 and doc site https://opensearch.org/docs/latest/ingest-pipelines/processors/kv/

@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. labels Jan 30, 2024
@gaobinlong
Copy link
Contributor Author

@gaobinlong - Does the merged PR contain the information being delivered in 2.12? I believe 5781 was written based on 2.11, but just want to confirm. Thanks!

@hdhalter @vagimeli , I see the PR #5781 has been backported to 2.11, but the functionality of field and target_field in kv processor supports template snippets which this issue calls out will be released in 2.12.0, and will not be backported to 2.11, so I think we should remove the description of Supports [template snippets] in the document of 2.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete v2.12.0
Projects
None yet
Development

No branches or pull requests

4 participants