Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Configuration section of the Security TOC (#2212) #2542

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

Naarcha-AWS
Copy link
Collaborator

  • fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum [email protected]

  • fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum [email protected]

  • fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum [email protected]

  • fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum [email protected]

  • fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum [email protected]

  • fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum [email protected]

  • fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum [email protected]

  • fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum [email protected]

  • fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum [email protected]

  • fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum [email protected]

  • fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum [email protected]

  • Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS [email protected]


Signed-off-by: cwillum [email protected]
Signed-off-by: Naarcha-AWS [email protected]
Co-authored-by: Naarcha-AWS [email protected]
(cherry picked from commit d04e88b)

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)
@Naarcha-AWS Naarcha-AWS requested a review from a team as a code owner January 31, 2023 21:39
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. But looks good.

@@ -9,11 +9,11 @@ has_children: false

Using the security plugin with index management lets you limit non-admin users to certain actions. For example, you might want to set up your security such that a group of users can only read ISM policies, while others can create, delete, or change policies.

All index management data are protected as system indices, and only a super admin or an admin with a Transport Layer Security (TLS) certificate can access system indices. For more information, see [System indices]({{site.url}}{{site.baseurl}}/security-plugin/configuration/system-indices).
All index management data are protected as system indices, and only a super admin or an admin with a Transport Layer Security (TLS) certificate can access system indices. For more information, see [System indices]({{site.url}}{{site.baseurl}}/security/configuration/system-indices).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this change from System indices to System indexes goes back to 1.3. It goes back at least to 2.2, so I'm guessing it should go further. Although the doc sites for 2.1 and earlier aren't publishing Security content.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll switch it here.

@@ -10,7 +10,7 @@ has_children: false

You can use the security plugin with anomaly detection in OpenSearch to limit non-admin users to specific actions. For example, you might want some users to only be able to create, update, or delete detectors, while others to only view detectors.

All anomaly detection indices are protected as system indices. Only a super admin user or an admin user with a TLS certificate can access system indices. For more information, see [System indices]({{site.url}}{{site.baseurl}}/security-plugin/configuration/system-indices/).
All anomaly detection indices are protected as system indices. Only a super admin user or an admin user with a TLS certificate can access system indices. For more information, see [System indices]({{site.url}}{{site.baseurl}}/security/configuration/system-indices/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this change from System indices to System indexes goes back to 1.3. It goes back at least to 2.2, so I'm guessing it should go further. Although the doc sites for 2.1 and earlier aren't publishing Security content.

@@ -160,7 +160,7 @@ Whereas query-level monitors run your specified query and then check whether the

To define a monitor visually, choose **Visual editor**. Then choose a source index, a timeframe, an aggregation (for example, `count()` or `average()`), a data filter if you want to monitor a subset of your source index, and a group-by field if you want to include an aggregation field in your query. At least one group-by field is required if you're defining a bucket-level monitor. Visual definition works well for most monitors.

If you use the security plugin, you can only choose indices that you have permission to access. For details, see [Alerting security]({{site.url}}{{site.baseurl}}/security-plugin/).
If you use the Security plugin, you can only choose indexes that you have permission to access. For details, see [Alerting security]({{site.url}}{{site.baseurl}}/security/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this link should be
/monitoring-plugins/alerting/security/

@@ -10,21 +10,21 @@ has_children: false

You can use the security plugin with asynchronous searches to limit non-admin users to specific actions. For example, you might want some users to only be able to submit or delete asynchronous searches, while you might want others to only view the results.

All asynchronous search indices are protected as system indices. Only a super admin user or an admin user with a Transport Layer Security (TLS) certificate can access system indices. For more information, see [System indices]({{site.url}}{{site.baseurl}}/security-plugin/configuration/system-indices/).
All asynchronous search indices are protected as system indices. Only a super admin user or an admin user with a Transport Layer Security (TLS) certificate can access system indices. For more information, see [System indices]({{site.url}}{{site.baseurl}}/security/configuration/system-indices/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. System indexes now, I think.

Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS merged commit e4d570b into 1.3 Feb 1, 2023
@Naarcha-AWS Naarcha-AWS deleted the backport/backport-2212-to-1 branch February 1, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants