Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Configuration section of the Security TOC #2212

Merged
merged 13 commits into from
Jan 27, 2023

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Dec 14, 2022

Signed-off-by: cwillum [email protected]

Description

Break out authentication backend topics in the Configuration section into their own section to clean things up and reorganize in a more logical manner.

Issues Resolved

Created a new "Authentication backends" section to contain the specific backends that were previously strewn in with straightforward configuration topics.
Also addressing some issues in topics to improve clarity and gaps.
Addresses issue #2155.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwillum cwillum added 2 - In progress Issue/PR: The issue or PR is in progress. security labels Dec 14, 2022
@cwillum cwillum added this to the 2022-Q4 milestone Dec 14, 2022
@cwillum cwillum requested a review from a team as a code owner December 14, 2022 00:44
@cwillum cwillum self-assigned this Dec 14, 2022
@cwillum cwillum marked this pull request as draft December 14, 2022 05:42
@cwillum cwillum marked this pull request as ready for review December 20, 2022 21:24
@cwillum cwillum added the 3 - Tech review PR: Tech review in progress label Dec 20, 2022
@cwillum cwillum requested a review from Naarcha-AWS December 20, 2022 22:41
@cwillum cwillum removed the 2 - In progress Issue/PR: The issue or PR is in progress. label Dec 20, 2022
@cwillum
Copy link
Contributor Author

cwillum commented Dec 20, 2022

@opensearch-project/security Team, I reorganized the TOC for Security documentation. The biggest difference is that I broke out the authentication backends and separated them from general configuration information so they have their own section (more of that to come in a separate issue). @cwperks has seen the reorg.
My ask is if you'd have a quick look at some language I changed at the intro/top of four sections (in the diffs). Just to be sure it makes sense. I'll list those here. Then you don't have to wade through the many minor TOC changes. Thanks.
_security-plugin/authentication-backends/authc-index.md
_security-plugin/configuration/security-admin.md
_security-plugin/configuration/system-indices.md
_security-plugin/configuration/yaml.md

@cwillum
Copy link
Contributor Author

cwillum commented Dec 20, 2022

@Naarcha-AWS Changes to the Security TOC are ready. I'll have you take a look first then pass it to another team member. Big thanks.

Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cwillum. I like breaking up the different authentication backends into menu items. I think that helps with discovery and navigation on the documentation website.

I left a couple of comments that I think can be addressed in future PRs as we work to make the documentation more precise and easy-to-follow.

@@ -678,11 +678,11 @@ PUT _plugins/_security/api/roles/<role>
}
```

>Due to word boundaries associated with Unicode special characters, the Unicode standard analyzer cannot index a [text field type](https://opensearch.org/docs/2.2/opensearch/supported-field-types/text/) value as a whole value when it includes one of these special characters. As a result, a text field value that includes a special character is parsed by the standard analyzer as multiple values separated by the special character, effectively tokenizing the different elements on either side of it.
>Due to word boundaries associated with Unicode special characters, the Unicode standard analyzer cannot index a [text field type]({{site.url}}{{site.baseurl}}/opensearch/supported-field-types/text/) value as a whole value when it includes one of these special characters. As a result, a text field value that includes a special character is parsed by the standard analyzer as multiple values separated by the special character, effectively tokenizing the different elements on either side of it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any automation in place to warn against the use of specific version urls?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we're using an automated link checker now. Not sure if it would identify this specific problem. But will look into it.

@@ -93,7 +93,7 @@ someonerole:

### REST API

See [Create role]({{site.url}}{{site.baseurl}}/security-plugin/access-control/api#create-role).
See [Create role]({{site.url}}{{site.baseurl}}/security-plugin/access-control/api/#create-role).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the addition of an extra slash when reference an ID on the API page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently both ways work. I just followed the lead of the web server, which adds the forward slash when you use the link. The doc team informed me that behavior originates with the web server. In any case, I see now there's no need bothering to add it from now on. Thanks.


These credentials differ depending on how you've configured the plugin. For example, if you use basic authentication, the credentials are a user name and password. If you use a JSON web token, the credentials are stored within the token itself. If you use TLS certificates, the credentials are the distinguished name (DN) of the certificate.

2. The security plugin authenticates the user's credentials against a backend: the internal user database, Lightweight Directory Access Protocol (LDAP), Active Directory, Kerberos, or JSON web tokens.
2. The Security plugin authenticates the user's credentials against a backend: the internal user database (basic authentictation), Lightweight Directory Access Protocol (LDAP)/Active Directory, JSON web tokens, SAML, or another authentication protocol.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about how to be precise and clear when communication about backend vs. way of communicating auth info (user + password combo or token) to OpenSearch.

There are 2 high-level types of IdP, Identity Providers, backends that Opensearch security plugin interfaces with. 1. Internal User database or 2. an external provider (a backend compliant with LDAP, ODIC or SAML). For client cert, jwt and proxy auth, these could be described as backend-less providers (not completely accurate, but I'll explain) in that OpenSearch does not verify the info passed in the request with a list of users and instead extracts username and backend roles from the request passed to opensearch.

  1. For client cert auth, the principal of the cert is used to extract the username and backend roles. I believe username is the CN field and backend_roles are the concatenated OU fields. As long as the cert is issued by a CA in the SECURITY_SSL_HTTP_PEMTRUSTEDCAS_FILEPATH setting the cert will be trusted.
  2. For JWT, a token is passed in an HTTP Authorization request header which must contain claims that match the subject_key and roles_key. The JWT must also be able to be verified with the signing_key configured in config.yml
  3. For proxy auth authentication is performed at the IdP and then forwarded to opensearch. The forwarded request contains the username and backend roles in the HTTP request and OpenSearch trusts the request if its coming from the correct configured source.

The internal database is used with Basic Auth to get username and password info from an HTTP request. So in this case Basic Auth is the mechanism for transmitting auth info (username + password) in a request and the Authentication Backend would be the internal user database.

How does this sound?

The Security plugin authenticates a request against a configured backend.  Authentication providers include: Basic Auth using the internal user database, Lightweight Directory Access Protocol (LDAP)/Active Directory, JSON web tokens, SAML, or another authentication protocol.

This change you are presenting in this PR looks good to me, but stuff to keep in mind.

Copy link
Contributor Author

@cwillum cwillum Dec 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the distinction. And those are good points to keep in mind. I tweaked the suggestion a little. Does it still make sense, or have I taken it off course?

The Security plugin authenticates a server request against a backend configured for an authentication provider. Some examples of authentication providers used with OpenSearch include Basic Auth (which uses the internal user database), Lightweight Directory Access Protocol (LDAP)/Active Directory, JSON web tokens, SAML, or another authentication protocol.

@cwperks Also, referring to item 1 in the flow, is it accurate to say that a user's credentials will be included in the request, no matter which authentication provider is being used? If I can say that, it will improve continuity with the statement in item 2 (continuity = better chance for making overall sense of the flow).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwillum The tweaked suggestion sounds good to me, but instead of server request can it simply be request?

Judging by item 1, the word Credentials is used generically to mean what's needed to confer access so its accurate to say that credentials must be included on every request.

For most of the backends, Username + Password will be used for the very first request so its accurate to say the credentials are included in the request. In many cases, subsequent requests will use an access token (JWT) to prevent the need of passing username + password on every request.

In item 1:

the credentials are stored within the token itself

When I first read this it sounded like password info was embedded in the token, but that's not the case. The username (subject_key) and roles (roles_key) are embedded in the token.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RE: "... but instead of server request can it simply be request?"
Definitely. I'm probably unnecessarily splitting hairs with some of these proposed changes to wording. But it's helpful to refine along the way. Thanks for your patience.


The plugin supports chaining backends in `config/opensearch-security/config.yml`. If more than one backend is present, the plugin tries to authenticate the user sequentially against each until one succeeds. A common use case is to combine the internal user database of the security plugin with LDAP/Active Directory.

3. After a backend verifies the user's credentials, the plugin collects any backend roles. These roles can be arbitrary strings in the internal user database, but in most cases, these backend roles come from LDAP/Active Directory.
3. After a backend verifies the user's credentials, the plugin collects any backend roles. These roles can be arbitrary strings in the internal user database, roles retrieved from the LDAP/Active Directory server, or roles that are kept as attributes with the SAML protocol.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extraction of backend roles is applicable for all backends except for basic auth with the internal user database. LDAP is a bit exceptional because authz of the security plugin's config.yml needs to be configured to specify how roles should be extracted from the directory service.

For the internal user database, roles are determined by roles that the user is mapped to within opensearch. With an external IdP, a cluster admin must map backend roles to roles in OpenSearch and users will transitively get OpenSearch roles based on the roles mapping. i.e. In LDAP I may be in the My Org Developers group, and in opensearch there could be a role named developers which has a certain set of permissions. The cluster admin would need to map My Org Developers to the developers role to map the external group to the internal role within OpenSearch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwperks I tried to sum this up while keeping it general.
After a backend verifies the user's credentials, the plugin collects any [backend roles]({{site.url}}{{site.baseurl}}/security-plugin/access-control/index/#concepts). The authentication provider determines the way these roles are retrieved. For example, LDAP extracts backend roles from its directory service based on their mappings to roles in OpenSearch, while SAML stores the roles as attributes. When basic authentication is used, the internal user database refers to role mappings configured in OpenSearch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@cwillum cwillum added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Jan 10, 2023
@cwillum
Copy link
Contributor Author

cwillum commented Jan 10, 2023

Still waiting for a review on this from @Naarcha-AWS . Removed Tech Review tag and replaced with Doc Review. Will sound out a request on doc team Slack channel once the first is done.

@@ -41,7 +41,7 @@ These permissions also allow you add, update, or delete documents (e.g. `PUT tes

## Test permissions

If you want a user to have the absolute minimum set of permissions necessary to perform some function---the [principle of least privilege](https://en.wikipedia.org/wiki/Principle_of_least_privilege)----the best way is to send representative requests to your cluster as a new test user. In the case of a permissions error, the security plugin is very explicit about which permissions are missing. Consider this request and response:
If you want a user to have the absolute minimum set of permissions necessary to perform some functionthe [principle of least privilege](https://en.wikipedia.org/wiki/Principle_of_least_privilege)the best way is to send representative requests to your cluster as a new test user. In the case of a permissions error, the security plugin is very explicit about which permissions are missing. Consider this request and response:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should p be capital as in [Principle of least privilege]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the internet generally uses lower case to name this principle. I think it should be OK.

```bash
curl -k --cert ./kirk.pem --key ./kirk-key.pem -XGET 'https://localhost:9200/.opendistro_security/_search'
```
You can add additional system indexes in `opensearch.yml`. An alternative way to remove indexes is to delete the index from the `plugins.security.system_indices.indices` list on each node and restart OpenSearch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indexes -> indices

And we can reword: "An alternative way to remove system indices is to delete them plugins.security.system_indices.indices\ list on each node and restart OpenSearch".

Also, I'm not sure what the original way to remove is. Should it be documented here ( maybe I'm missing something here). Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I got tripped up on this, too, and made a note of it. It comes out of the blue. If you're going to describe an alternative, you have to provide a primary way of doing something before it. Thanks. Still, I'm not sure myself what the preferred way of deleting an index is.

RE: Indices/indexes. This is probably the most hated change that developers can see in the documentation now. But the usage of "indexes" appears to have crossed the line into common usage, including AWS documentation, and the documentation is going full speed with it, with the exception of what already exists in the code.
(I even heard pundits using "indexes" on Bloomberg news the other week, finance being one of the last hold outs: FTSE, NASDAQ indices are traditional.)

I like your suggestion. When we find out the preferred way, maybe I can find a place to add both and rewrite in the singular:
"An alternative way to remove a system index is to delete it from the plugins.security.system_indices.indices\ list on each node and restart OpenSearch."
(Is the backslash needed in plugins.security.system_indices.indices\? I don't see the slash appear in the opensearch.yml.example file in Config.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: An alternative way... This should definitely be addressed at some point to clearly defined in the document. Not urgent for this change tho.

Re: indices/indexes I've been confused about this too, but as you mentioned in the dev world afaik it has always been indices. However, I'm completely fine with either as long as the whole documentation is aligned and points to the same usage

Re: \ yes the backslash was a typo on my end. It shouldn't contain any backslash. And, I like your suggestion to rewrite it to be singular.

The best use of these YAML files is to configure [reserved and hidden resources]({{site.url}}{{site.baseurl}}/security-plugin/access-control/api#reserved-and-hidden-resources), such as the `admin` and `kibanaserver` users. You might find it easier to create other users, roles, mappings, action groups, and tenants using OpenSearch Dashboards or the REST API.
Before running [`securityadmin.sh`]({{site.url}}{{site.baseurl}}/security-plugin/configuration/security-admin/) to load the settings into the `.opendistro_security` index, perform an initial configuration of the YAML files. The files can be found in the `config/opensearch-security` directory. It's also good practice to back up these files so that you can reuse them for other clusters.

One approach to using the YAML files—which we recommend—is to first configure [reserved and hidden resources]({{site.url}}{{site.baseurl}}/security-plugin/access-control/api#reserved-and-hidden-resources), such as the `admin` and `kibanaserver` users. Thereafter you can create other users, roles, mappings, action groups, and tenants using OpenSearch Dashboards or the REST API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on using - here instead of , surrounding which we recommend?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote like so: "The approach we recommend for using the YAML files is to first configure ..."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this is even better


# Authentication backends

Authentication backend configurations determine the method or methods you use for authenticating users and the way users pass their credentials and sign in to OpenSearch. Having an understanding of the basic authentication flow before getting started can help with the configuration process for whichever backend you choose. Consider the high-level sequence of events in the description that follows, and then refer to the detailed steps for configuring the authentication type you choose to use with OpenSearch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on: .. the method/s to be used for authenticating users ..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're trying to stay away from shorthand like this in the documentation. But I would be fine with using the singular "method" alone. I don't think it confuses the meaning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, singular usage sounds good and it won't divert the user interpretation of this sentence.

@@ -2,7 +2,7 @@
layout: default
title: API
parent: Access control
nav_order: 90
nav_order: 120
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generic question: Changing nav_order will re-organize this document based on the value entered. Correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's the method for ordering topics in the TOC. This is how the TOC will look after merging this PR.
SEC_TOC
I will be breaking out two new sections for "Authentication Backends" once this is merged and the new structure is in place (Basic Authentication and JWT). But it doesn't make sense to do it in this PR, or until the new structure is in place. Once the review is complete for this, I'll get started on that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oo nice..thank you for sharing the final view. This helps a lot in visualizing the "re-organization" of the Security Plugin section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. It helps.

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cwillum !

@Naarcha-AWS Naarcha-AWS added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 labels Jan 30, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-2212-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d04e88b496485474fc3d89bd42ea36e834d6a64c
# Push it to GitHub
git push --set-upstream origin backport/backport-2212-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-2212-to-1.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-2212-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d04e88b496485474fc3d89bd42ea36e834d6a64c
# Push it to GitHub
git push --set-upstream origin backport/backport-2212-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-2212-to-2.0.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.2 2.2
# Navigate to the new working tree
cd .worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-2212-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d04e88b496485474fc3d89bd42ea36e834d6a64c
# Push it to GitHub
git push --set-upstream origin backport/backport-2212-to-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.2

Then, create a pull request where the base branch is 2.2 and the compare/head branch is backport/backport-2212-to-2.2.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 30, 2023
* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.1 2.1
# Navigate to the new working tree
cd .worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-2212-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d04e88b496485474fc3d89bd42ea36e834d6a64c
# Push it to GitHub
git push --set-upstream origin backport/backport-2212-to-2.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.1

Then, create a pull request where the base branch is 2.1 and the compare/head branch is backport/backport-2212-to-2.1.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 30, 2023
* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-2212-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d04e88b496485474fc3d89bd42ea36e834d6a64c
# Push it to GitHub
git push --set-upstream origin backport/backport-2212-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3

Then, create a pull request where the base branch is 2.3 and the compare/head branch is backport/backport-2212-to-2.3.

Naarcha-AWS pushed a commit that referenced this pull request Jan 30, 2023
* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)

Co-authored-by: Chris Moore <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Jan 30, 2023
* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)

Co-authored-by: Chris Moore <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Jan 31, 2023
* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)
Naarcha-AWS added a commit that referenced this pull request Jan 31, 2023
* Reorganize Configuration section of the Security TOC (#2212)

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)

* fix links

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Chris Moore <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Jan 31, 2023
* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)
Naarcha-AWS added a commit that referenced this pull request Jan 31, 2023
* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)

Co-authored-by: Chris Moore <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Jan 31, 2023
* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)
Naarcha-AWS added a commit that referenced this pull request Feb 1, 2023
* Reorganize Configuration section of the Security TOC (#2212)

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)

* Rename system indices

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Chris Moore <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Feb 1, 2023
* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)
Naarcha-AWS added a commit that referenced this pull request Feb 1, 2023
* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)

Co-authored-by: Chris Moore <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Feb 1, 2023
* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)
Naarcha-AWS added a commit that referenced this pull request Feb 1, 2023
* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* fix#2155-sec-toc-config-reorg

Signed-off-by: cwillum <[email protected]>

* Rename security section. Fix links. Add redirects

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit d04e88b)

Co-authored-by: Chris Moore <[email protected]>
@Naarcha-AWS Naarcha-AWS deleted the fix#2155-Sec-TOC-config-reorg branch March 28, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants