[Backport 1.2] Fix innerproduct function to match Dot Product #1126
Conversation
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f)
JeffHuss
dismissed
their stale review
Accidentally approved. This shouldn't be merged - it's not correct syntax.
|
@JeffH-AWS: Fanit and I agreed it's more understandable without the dot or parentheses included. |
If that's the case then you need to change it for the other formulas as well. I personally don't think it makes it more readable, and the inconsistency makes it extremely confusing. |
|
The dot notation is implied in multiplication in math, so having a dot there does not add information. We should change this for other formulas that use the same notation. Also, we agreed to create an issue to make all vector notation unified: vectors will be denoted with lowercase bold letters, and scalars will be denoted with lowercase non-bold letters. This is the standard vector notation in math. @Naarcha-AWS - could you create an issue for that or should I? I can take it on when it's created. |
|
I'll go ahead and create the issue. |
Backport d65b56f from #1004