Fix innerproduct function to match Dot Product #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
added
backport 2.0
Naarcha-AWS
added
3 - Tech review
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
added
backport 2.0
kolchfa-aws
reviewed
Aug 29, 2022
| @@ -313,7 +313,7 @@ A space corresponds to the function used to measure the distance between two poi | |||
| </tr> | |||
| <tr> | |||
| <td>innerproduct</td> | |||
| <td>\[ Distance(X, Y) = \sum_{i=1}^n (X_i - Y_i) \]</td> | |||
| <td>\[ Distance(X, Y) = \sum_{i=1}^n (X_i * Y_i) \]</td> | |||
There was a problem hiding this comment.
Should we use the math multiplication sign (dot) instead of the programming multiplication sign (*) here? Or we can omit the multiplication sign altogether because multiplication is implicit in math. If you omit the multiplication sign, parentheses are not needed here.
In general, should we denote vectors as lowercase(or uppercase) bold letters and scalars as lowercase non-bold letters? I think this notation is easier to understand and is the default mathematical notation for vectors.
There was a problem hiding this comment.
Switched to dot. Let's address the 2nd comment in a different issue, since that would require changing more than just this formula.
cwillum
approved these changes
Aug 29, 2022
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f)
Naarcha-AWS
added a commit
that referenced
this pull request
Sep 1, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f) Co-authored-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
added a commit
that referenced
this pull request
Sep 1, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f) Co-authored-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
added a commit
that referenced
this pull request
Sep 1, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f) Co-authored-by: Naarcha-AWS <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 7, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f)
Naarcha-AWS
added
backport 1.2
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 7, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 7, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f)
Naarcha-AWS
added a commit
that referenced
this pull request
Sep 7, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f) Co-authored-by: Naarcha-AWS <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 7, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f)
Naarcha-AWS
added a commit
that referenced
this pull request
Sep 8, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f) Co-authored-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
added a commit
that referenced
this pull request
Sep 8, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f) Co-authored-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
added a commit
that referenced
this pull request
Sep 8, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit d65b56f) Co-authored-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
added a commit
that referenced
this pull request
Oct 6, 2022
* Fix innerproduct function to match Dot Product Signed-off-by: Naarcha-AWS <[email protected]> * Fix formatting Signed-off-by: Naarcha-AWS <[email protected]> * Use dot instead Signed-off-by: Naarcha-AWS <[email protected]> * Remove parenthesies Signed-off-by: Naarcha-AWS <[email protected]> * Remove space Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naarcha-AWS [email protected]
Issues Resolved
Fixes #397
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.