Fixes javadocs errors and updates deprecated Gradle dependency config… #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration Signed-off-by: Shivani Shukla <[email protected]>
sshivanii
changed the title
sshivanii
changed the title
dlvenable
reviewed
Nov 15, 2021
| @@ -150,7 +150,7 @@ task basicLogEndToEndTest(type: Test) { | |||
|
|
|||
| dependencies { | |||
| implementation "com.github.javafaker:javafaker:1.0.2" | |||
| integrationTestCompile project(':data-prepper-plugins:opensearch') | |||
| integrationTestImplementation project(':data-prepper-plugins:opensearch') | |||
There was a problem hiding this comment.
Thanks for fixing these as well!
dlvenable
approved these changes
Nov 15, 2021
5 tasks
dapowers87
pushed a commit
to dapowers87/data-prepper
that referenced
this pull request
Nov 18, 2021
…uration (opensearch-project#597) Signed-off-by: Shivani Shukla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uration
Signed-off-by: Shivani Shukla [email protected]
Description
data-prepper-plugins:commonanddata-prepper-apiand some warningsimplementationsincecompilewill get deprecated in Gradle 7.0. See referenceIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.