-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unsigned Maven publication. Set groupId to org.opensearch.dataprepper #596
Support unsigned Maven publication. Set groupId to org.opensearch.dataprepper #596
Conversation
Codecov Report
@@ Coverage Diff @@
## main #596 +/- ##
=========================================
Coverage 91.70% 91.70%
Complexity 571 571
=========================================
Files 72 72
Lines 1747 1747
Branches 145 145
=========================================
Hits 1602 1602
Misses 113 113
Partials 32 32 Continue to review full report at Codecov.
|
@@ -11,7 +12,7 @@ allprojects { | |||
apply plugin: 'checkstyle' | |||
apply plugin: 'com.diffplug.spotless' | |||
|
|||
group = 'com.amazon' | |||
group = 'org.opensearch.dataprepper' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to update all sub-projects to use 'org.opensearch.dataprepper'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure exactly what you mean.
By convention the Maven groupId is the beginning of Java package names. Data Prepper 2.0 is scheduled to update all Java package names to org.opensearch.dataprepper
as part of #344.
Because this project has not yet been deployed, the Maven groupId is currently not used. So this is not a breaking change.
build.gradle
Outdated
@@ -94,6 +96,43 @@ configure(subprojects.findAll {it.name != 'data-prepper-api'}) { | |||
} | |||
} | |||
|
|||
configure(mavenArtifactProjects) { | |||
java { | |||
// TODO: Add once Javadocs are working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be updated now that the Javadocs are fixed in #597
build-resources.gradle
Outdated
ext.coreProjects = [project(':data-prepper-api'), project(':data-prepper-core'), project('data-prepper-plugins:common')] | ||
ext.mavenArtifactProjects = [project(':data-prepper-api'), project('data-prepper-plugins:common')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to publish the common plugins? How does this help plugin developers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't need them, can we add the publishing instructions to the plugin build.gradle file instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took another look at common
. I believe we can remove it from the publication.
If we don't need them, can we add the publishing instructions to the plugin build.gradle file instead?
Can you elaborate on this request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I mixed plugins and api in my original ask. I was thinking we could have the publishing instructions closer to the package that we are publishing but this works as is.
maven(MavenPublication) { | ||
from components.java | ||
pom { | ||
name = project.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the project name that gets published here? Are we publishing multiple projects here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the name of the current project. Thus, it will data-prepper-api
and common
. Though, per the discussion above, I will remove common
.
…g.opensearch.dataprepper. Supports opensearch-project#421 Signed-off-by: David Venable <[email protected]>
Signed-off-by: David Venable <[email protected]>
2ca0ace
to
43eb108
Compare
I had to force push the second commit because I needed the Javadoc work from #597 . |
… Development guide. Signed-off-by: David Venable <[email protected]>
…aprepper (opensearch-project#596) Support unsigned Maven publication. Updated the project groupId to org.opensearch.dataprepper. Added some documentation for publishing Maven artifacts to the Plugin Development guide. Supports opensearch-project#421 Signed-off-by: David Venable <[email protected]>
Description
org.opensearch.dataprepper
.Issues Resolved
Supports #421
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.